Details
-
Improvement
-
Resolution: Unresolved
-
Minor
-
None
-
None
-
None
-
9223372036854775807
Description
setupall function under test-framework never fails. Even if the mount from mount[mgs/oss] or mount_facet() call is a faiure. Somewhere within a chain of calls from setupall() to do_nodes() the return value is getting washed away and 0 is returning
Reproducer:
test_1400() { sync; sync_all_data; sleep 3; sync_all_data echo "********** Stopping" stopall # options passed is on purpose given will fail # as rdonly_dev is not supported MGS_MOUNT_OPTS=$(csa_add "$MGS_MOUNT_OPTS" -o rdonly_dev) MDS_MOUNT_OPTS=$(csa_add "$MDS_MOUNT_OPTS" -o rdonly_dev) OST_MOUNT_OPTS=$(csa_add "$OST_MOUNT_OPTS" -o rdonly_dev) echo "................starting again!!! ............" setupall server_only || error "FAILED SETUPALL!!!" echo "Return Value = $?" } run_test 1400 "Sample test to demonstrate setupall never fails"
Output: (Important parts only)
++ cd /root/lustre-dev/lustre-release ++ LUSTRE=/root/lustre-dev/lustre-release/lustre/tests/.. ++ bash -c 'mkdir -p /mnt/lustre-mds1; mount -t lustre -o localrecov,rdonly_dev /dev/mapper/mds1_flakey /mnt/lustre-mds1' mount.lustre: mount /dev/mapper/mds1_flakey at /mnt/lustre-mds1 failed: Operation not supported + return 95 # >>>>> (do_nodes correctly see the error message) + RC=95 + '[' 95 -ne 0 ']' + echo '110 Start of /dev/mapper/mds1_flakey on mds1 failed 95' 110 Start of /dev/mapper/mds1_flakey on mds1 failed 95 Return Value = 0 # >>>>>>> (actual return is somewhere it is getting lost - returing the value 0) PASS 1400 (17s)
Dmesg
kernel: Lustre: lustre-MDT0000-osd: not support dev_rdonly on this device kernel: LustreError: 16127:0:(obd_config.c:774:class_setup()) setup lustre-MDT0000-osd failed (-95) kernel: LustreError: 16127:0:(obd_mount.c:200:lustre_start_simple()) lustre-MDT0000-osd setup error -95 kernel: LustreError: 16127:0:(obd_mount_server.c:2018:server_fill_super()) Unable to start osd on /dev/mapper/mds1_flakey: -95 kernel: LustreError: 16127:0:(super25.c:178:lustre_fill_super()) llite: Unable to mount <unknown>: rc = -95