Uploaded image for project: 'Lustre'
  1. Lustre
  2. LU-15923

ll_dir_ioctl():function puts 1128 bytes on stack

    XMLWordPrintable

Details

    • Bug
    • Resolution: Unresolved
    • Minor
    • Lustre 2.16.0
    • Lustre 2.15.0
    • None
    • 3
    • 9223372036854775807

    Description

      Oleg, it looks like the Misc Code Checks Robot is reporting an error in the commit messsage of every patch:

      Misc Code Checks Robot (Gatekeeper helper)
      If you believe the warnings are incorrect, please leave a comment with your explanations as a reply to the warning.
      
      Line 1:  lustre/llite/dir.c:
       warn: ll_dir_ioctl():function puts 1128 bytes on stack
      

      I ran "make checkstack" on el7.9 and el8.5 and it didn't show this much stack usage, only about 512 bytes, and I didn't see any large structures being declared. Could this be caused by aggressive inline of functions being called? Outside of krb5 functions, the major users are:

      544 lustre:ll_lookup_it
      528 ptlrpc_gss:rsc_parse
      512 lustre:ll_dir_ioctl
      352 osc:osc_page_print
      336 mgc:mgc_apply_recover_logs
      312 ptlrpc:_debug_req
      

      Attachments

        Activity

          People

            green Oleg Drokin
            adilger Andreas Dilger
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated: