Uploaded image for project: 'Lustre'
  1. Lustre
  2. LU-16160

take ldlm lock when queue sync pages

Details

    • 3
    • 9223372036854775807

    Description

      osc_queue_sync_pages() add osc_extent to osc_object's IO extent list without taking ldlm locks, and then it calls osc_io_unplug_async() to queue the IO work for the client.

      I think the IO extent should take ldlm locks while waiting in the IO work queue.

      Attachments

        Issue Links

          is related to

          Bug - A problem which impairs or prevents the functions of the product. LU-16401 various crashes with cl_page_discard vs readhead race

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Open

          Bug - A problem which impairs or prevents the functions of the product. LU-16224 rw_seq_cst_vs_drop_caches dies with SIGBUS

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Resolved
          is related to

          Bug - A problem which impairs or prevents the functions of the product. LU-16156 stale read during IOR test due LU-14541

          • Blocker - Blocks development and/or testing work, production could not run.
          • Open

          Bug - A problem which impairs or prevents the functions of the product. LU-14541 Memory reclaim caused a stale data read

          • Critical - Crashes, loss of data, severe memory leak.
          • Resolved

          Bug - A problem which impairs or prevents the functions of the product. LU-15815 fast_read/stale data/reclaim workround causes SIGBUS

          • Critical - Crashes, loss of data, severe memory leak.
          • Resolved

          Activity

            [LU-16160] take ldlm lock when queue sync pages
            gerrit Gerrit Updater added a comment -

            "Oleg Drokin <green@whamcloud.com>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/50202/
            Subject: LU-16160 llite: SIGBUS is possible on a race with page reclaim
            Project: fs/lustre-release
            Branch: b2_15
            Current Patch Set:
            Commit: b0a6d4d08e19d06661deabdb7278f07662d8b6e8

            gerrit Gerrit Updater added a comment - "Oleg Drokin <green@whamcloud.com>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/50202/ Subject: LU-16160 llite: SIGBUS is possible on a race with page reclaim Project: fs/lustre-release Branch: b2_15 Current Patch Set: Commit: b0a6d4d08e19d06661deabdb7278f07662d8b6e8
            pjones Peter Jones added a comment -

            Looks like everything tracked under this ticket has landed for 2.16

            pjones Peter Jones added a comment - Looks like everything tracked under this ticket has landed for 2.16
            gerrit Gerrit Updater added a comment -

            "Patrick Farrell <pfarrell@whamcloud.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/50202
            Subject: LU-16160 llite: SIGBUS is possible on a race with page reclaim
            Project: fs/lustre-release
            Branch: b2_15
            Current Patch Set: 1
            Commit: f817fcd2c553c223fc89087f62c9d59517bb8e59

            gerrit Gerrit Updater added a comment - "Patrick Farrell <pfarrell@whamcloud.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/50202 Subject: LU-16160 llite: SIGBUS is possible on a race with page reclaim Project: fs/lustre-release Branch: b2_15 Current Patch Set: 1 Commit: f817fcd2c553c223fc89087f62c9d59517bb8e59
            gerrit Gerrit Updater added a comment -

            "Oleg Drokin <green@whamcloud.com>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/49647/
            Subject: LU-16160 llite: SIGBUS is possible on a race with page reclaim
            Project: fs/lustre-release
            Branch: master
            Current Patch Set:
            Commit: b4da788a819f82d35b685d6ee7f02809c05ca005

            gerrit Gerrit Updater added a comment - "Oleg Drokin <green@whamcloud.com>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/49647/ Subject: LU-16160 llite: SIGBUS is possible on a race with page reclaim Project: fs/lustre-release Branch: master Current Patch Set: Commit: b4da788a819f82d35b685d6ee7f02809c05ca005
            gerrit Gerrit Updater added a comment -

            "Oleg Drokin <green@whamcloud.com>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/49541/
            Subject: LU-16160 revert: "llite: clear stale page's uptodate bit"
            Project: fs/lustre-release
            Branch: master
            Current Patch Set:
            Commit: 84c9618190f9e3a526ce51dc4995fcfa3a9ed265

            gerrit Gerrit Updater added a comment - "Oleg Drokin <green@whamcloud.com>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/49541/ Subject: LU-16160 revert: "llite: clear stale page's uptodate bit" Project: fs/lustre-release Branch: master Current Patch Set: Commit: 84c9618190f9e3a526ce51dc4995fcfa3a9ed265
            pjones Peter Jones added a comment -

            panda Patrick ported your attached patch to master and pushed it into gerrit, so we can compare and contrast both similar approaches. To that end, please can you confirm that nothing was altered during the porting? Thanks!

            pjones Peter Jones added a comment - panda  Patrick ported your attached patch to master and pushed it into gerrit, so we can compare and contrast both similar approaches. To that end, please can you confirm that nothing was altered during the porting? Thanks!
            gerrit Gerrit Updater added a comment -

            "Patrick Farrell <farr0186@gmail.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/49647
            Subject: LU-16160 llite: SIGBUS is possible on a race with page reclaim
            Project: fs/lustre-release
            Branch: master
            Current Patch Set: 1
            Commit: 371d94fe71b103c1712bf8f2b1bb1c026cf31de4

            gerrit Gerrit Updater added a comment - "Patrick Farrell <farr0186@gmail.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/49647 Subject: LU-16160 llite: SIGBUS is possible on a race with page reclaim Project: fs/lustre-release Branch: master Current Patch Set: 1 Commit: 371d94fe71b103c1712bf8f2b1bb1c026cf31de4
            panda Andrew Perepechko added a comment -

            Peter, sure, I'll do that. Thank you

            panda Andrew Perepechko added a comment - Peter, sure, I'll do that. Thank you
            pjones Peter Jones added a comment -

            Andrew

            Bobijam feels that your attached patch takes a similar approach to his latest LU-16160 patch. Could you please review the latter in gerrit to flag any issues that should deter us from landing this to master?

            Thanks

            Peter

            pjones Peter Jones added a comment - Andrew Bobijam feels that your attached patch takes a similar approach to his latest LU-16160 patch . Could you please review the latter in gerrit to flag any issues that should deter us from landing this to master? Thanks Peter
            pjones Peter Jones added a comment -

            Thanks very much Andrew. Is it possible to push the patch into gerrit so it is easier for us to provide testing/review feedback?

            pjones Peter Jones added a comment - Thanks very much Andrew. Is it possible to push the patch into gerrit so it is easier for us to provide testing/review feedback?

            People

              bobijam Zhenyu Xu
              bobijam Zhenyu Xu
              Votes:
              0 Vote for this issue
              Watchers:
              15 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: