[LU-16167] lctl llog_print do not print all record

• Type: Bug
• Resolution: Fixed
• Priority: Minor
• Fix Version/s: Lustre 2.16.0, Lustre 2.15.4
• Affects Version/s: Lustre 2.15.0, Lustre 2.15.1
• Labels: llog
• Severity: 3
• Assignee: Etienne Aujames
• Reporter: Etienne Aujames

Description

If a lot of contiguous records are skipped (>64), llog_print will stop the processing and will not display the last records.

With the https://review.whamcloud.com/45332 ("LU-15142 lctl: fixes for set_param -P and llog_print"), the following code is not true anymore:

 int jt_llog_print_iter(char *logname, long start, long end,
...
                /* There is no "end of list" marker, record was not modified */
                if (strcmp(record, logname) == 0)                <------
                        break;                                                 

"record" could be unmodified if all processed records are skipped.

"llog_print -r" is not affected by this issue.

Issue Links

• is related to: LU-15142 LCTL: permanent parameter deletion and llog_print issues

Comments

[Gerrit Updater]

"Oleg Drokin <[e-mail]>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/51221/
Subject: LU-16167 obdclass: fix lctl llog_print with skipped records
Project: fs/lustre-release
Branch: b2_15
Current Patch Set:
Commit: 73888fd0970dd6e45162b9244edd4573bfe7aae6

[Gerrit Updater]

"Etienne AUJAMES <[e-mail]>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/51221
Subject: LU-16167 obdclass: fix lctl llog_print with skipped records
Project: fs/lustre-release
Branch: b2_15
Current Patch Set: 1
Commit: 9db96d00238d23b7bdbfd020919b87e636b7c532

[Peter Jones]

Landed for 2.16

[Gerrit Updater]

"Oleg Drokin <[e-mail]>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/48586/
Subject: LU-16167 obdclass: fix lctl llog_print with skipped records
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: c6da54aa7546440339265c644538d3d109e46bde