Uploaded image for project: 'Lustre'
  1. Lustre
  2. LU-16258

Explicitly support .splice_write

Details

    • 3
    • 9223372036854775807

    Description

          Linux commit v5.9-rc1-6-g36e2c7421f02
            fs: don't allow splice read/write without explicit ops
          
          Lustre supports splice_write and previously provide handlers
          for splice_read.
          Explicitly use iter_file_splice_write, if it exists.

      Attachments

        Issue Links

          is related to

          Bug - A problem which impairs or prevents the functions of the product. LU-16020 sanity test_244a: FAIL: sendfile+grouplock failed

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Resolved

          Improvement - An improvement or enhancement to an existing feature or task. LU-15781 Ubuntu 22.04 LTS release support

          • Major - Major loss of function.
          • Resolved

          Activity

            [LU-16258] Explicitly support .splice_write
            gerrit Gerrit Updater added a comment -

            "Oleg Drokin <green@whamcloud.com>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/49058/
            Subject: LU-16258 llite: Explicitly support .splice_write
            Project: fs/lustre-release
            Branch: b2_15
            Current Patch Set:
            Commit: d0b3f364b14d484906ab862eebeed43adb36fb40

            gerrit Gerrit Updater added a comment - "Oleg Drokin <green@whamcloud.com>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/49058/ Subject: LU-16258 llite: Explicitly support .splice_write Project: fs/lustre-release Branch: b2_15 Current Patch Set: Commit: d0b3f364b14d484906ab862eebeed43adb36fb40
            gerrit Gerrit Updater added a comment -

            "Xing Huang <hxing@ddn.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/49058
            Subject: LU-16258 llite: Explicitly support .splice_write
            Project: fs/lustre-release
            Branch: b2_15
            Current Patch Set: 1
            Commit: fdd23437bfca5a692df6460f8454688e292b67bf

            gerrit Gerrit Updater added a comment - "Xing Huang <hxing@ddn.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/49058 Subject: LU-16258 llite: Explicitly support .splice_write Project: fs/lustre-release Branch: b2_15 Current Patch Set: 1 Commit: fdd23437bfca5a692df6460f8454688e292b67bf
            pjones Peter Jones added a comment -

            Landed for 2.16

            pjones Peter Jones added a comment - Landed for 2.16
            gerrit Gerrit Updater added a comment -

            "Oleg Drokin <green@whamcloud.com>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/48928/
            Subject: LU-16258 llite: Explicitly support .splice_write
            Project: fs/lustre-release
            Branch: master
            Current Patch Set:
            Commit: c619b6d6a54235cc0e34a65cf5916a632f4011c3

            gerrit Gerrit Updater added a comment - "Oleg Drokin <green@whamcloud.com>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/48928/ Subject: LU-16258 llite: Explicitly support .splice_write Project: fs/lustre-release Branch: master Current Patch Set: Commit: c619b6d6a54235cc0e34a65cf5916a632f4011c3
            adilger Andreas Dilger added a comment -

            To answer my own question, yes this patch definitely fixes sanity test_244a.

            adilger Andreas Dilger added a comment - To answer my own question, yes this patch definitely fixes sanity test_244a.
            adilger Andreas Dilger added a comment -

            Shaun, is there any chance that this patch would also fix LU-16020? That looks like a problem with sendfile on newer kernels. I was going to land a patch disable the test until someone could look at it, so that Ubuntu22.04 and RHEL9.0 could start having enforced test runs, but I'd much rather fix the test to pass.

            adilger Andreas Dilger added a comment - Shaun, is there any chance that this patch would also fix LU-16020 ? That looks like a problem with sendfile on newer kernels. I was going to land a patch disable the test until someone could look at it, so that Ubuntu22.04 and RHEL9.0 could start having enforced test runs, but I'd much rather fix the test to pass.
            gerrit Gerrit Updater added a comment -

            "Shaun Tancheff <shaun.tancheff@hpe.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/48928
            Subject: LU-16258 llite: Explicitly support .splice_write
            Project: fs/lustre-release
            Branch: master
            Current Patch Set: 1
            Commit: 7a8b83637b056fbc208ff8cc1da69301f197c738

            gerrit Gerrit Updater added a comment - "Shaun Tancheff <shaun.tancheff@hpe.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/48928 Subject: LU-16258 llite: Explicitly support .splice_write Project: fs/lustre-release Branch: master Current Patch Set: 1 Commit: 7a8b83637b056fbc208ff8cc1da69301f197c738

            People

              stancheff Shaun Tancheff
              stancheff Shaun Tancheff
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: