Uploaded image for project: 'Lustre'
  1. Lustre
  2. LU-16284

'lfs getstripe' follows symlink by default

Details

    • Improvement
    • Resolution: Fixed
    • Minor
    • Lustre 2.16.0, Lustre 2.15.4
    • Lustre 2.0.0
    • None
    • 9223372036854775807

    Description

      From DDN-3436, by Andreas:

      It makes sense that getstripe should print the target information (assuming it is in Lustre at all). This is complicated a bit by the fact that getstripe looks up the name of the symlink on the MDS and it has no striping info, and never opens the symlink at all.

      What makes sense is for the "lfs getstripe" code on the client to detect this is a symlink (the file type is already known during traversal) and do a separate lookup of the target file/dir, unless a "--no-follow" option is given.

      Attachments

        Issue Links

          is related to

          Bug - A problem which impairs or prevents the functions of the product. LU-5170 lfs usability

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Open

          Activity

            [LU-16284] 'lfs getstripe' follows symlink by default
            gerrit Gerrit Updater added a comment -

            "Oleg Drokin <green@whamcloud.com>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/53162/
            Subject: LU-16284 utils: lfs getstripe follows symlink
            Project: fs/lustre-release
            Branch: b2_15
            Current Patch Set:
            Commit: 6f2b56e0fd8e60137b8fcacd82ce1bea4c07f9a6

            gerrit Gerrit Updater added a comment - "Oleg Drokin <green@whamcloud.com>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/53162/ Subject: LU-16284 utils: lfs getstripe follows symlink Project: fs/lustre-release Branch: b2_15 Current Patch Set: Commit: 6f2b56e0fd8e60137b8fcacd82ce1bea4c07f9a6
            gerrit Gerrit Updater added a comment -

            "Xing Huang <hxing@ddn.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/53162
            Subject: LU-16284 utils: lfs getstripe follows symlink
            Project: fs/lustre-release
            Branch: b2_15
            Current Patch Set: 1
            Commit: 4ec135bde26872ebfd59b81537822710730d86c7

            gerrit Gerrit Updater added a comment - "Xing Huang <hxing@ddn.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/53162 Subject: LU-16284 utils: lfs getstripe follows symlink Project: fs/lustre-release Branch: b2_15 Current Patch Set: 1 Commit: 4ec135bde26872ebfd59b81537822710730d86c7
            pjones Peter Jones added a comment -

            Landed for 2.16

            pjones Peter Jones added a comment - Landed for 2.16
            gerrit Gerrit Updater added a comment -

            "Oleg Drokin <green@whamcloud.com>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/49003/
            Subject: LU-16284 utils: lfs getstripe follows symlink
            Project: fs/lustre-release
            Branch: master
            Current Patch Set:
            Commit: af32b516593dbf2a8e7a85d885c33fd017926ada

            gerrit Gerrit Updater added a comment - "Oleg Drokin <green@whamcloud.com>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/49003/ Subject: LU-16284 utils: lfs getstripe follows symlink Project: fs/lustre-release Branch: master Current Patch Set: Commit: af32b516593dbf2a8e7a85d885c33fd017926ada
            flei Feng Lei added a comment -

            adilger 

            It seems that changing the default behavior from "no-follow" to "follow" causes other problems (sanity test_56k in https://review.whamcloud.com/c/fs/lustre-release/+/49003).

            Is it OK to add "–follow" option to follow symlink and keep the original behavior (no-follow)?

            flei Feng Lei added a comment - adilger   It seems that changing the default behavior from "no-follow" to "follow" causes other problems (sanity test_56k in https://review.whamcloud.com/c/fs/lustre-release/+/49003 ). Is it OK to add "–follow" option to follow symlink and keep the original behavior (no-follow)?
            gerrit Gerrit Updater added a comment -

            "Feng Lei <flei@whamcloud.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/49003
            Subject: LU-16284 utils: lfs getstripe follows symlink
            Project: fs/lustre-release
            Branch: master
            Current Patch Set: 1
            Commit: b1753379b9a8a2df628fa931a4d3dbeeba632924

            gerrit Gerrit Updater added a comment - "Feng Lei <flei@whamcloud.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/49003 Subject: LU-16284 utils: lfs getstripe follows symlink Project: fs/lustre-release Branch: master Current Patch Set: 1 Commit: b1753379b9a8a2df628fa931a4d3dbeeba632924

            People

              flei Feng Lei
              flei Feng Lei
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: