Uploaded image for project: 'Lustre'
  1. Lustre
  2. LU-16313

PCC: change PCC type with bit matching for attach

Details

    • Improvement
    • Resolution: Fixed
    • Minor
    • Lustre 2.16.0
    • None
    • None
    • 9223372036854775807

    Description

      We only support two PCC type: readonly and readwirte:

      enum lu_pcc_type {
          LU_PCC_NONE = 0,
          LU_PCC_READWRITE,
          LU_PCC_READONLY,
          LU_PCC_MAX
      };
      struct lu_pcc_attach {
          __u32 pcca_type; /* PCC type */
          __u32 pcca_id; /* archive ID for readwrite, group ID for readonly */
      };

      The attach  data structure @lu_pcc_attach is using 32 bit @pcca_type to determine the type.

      we could change it from "== LU_PCC_READWRITE" to "&LU_PCC_READWRITE" to determine the PCC type via 2 bit matching. The left bits can be used as other flags for PCC attach such the asynchronous attach via the command "lfs pcc attach -A".

      Attachments

        Activity

          [LU-16313] PCC: change PCC type with bit matching for attach
          pjones Peter Jones added a comment -

          Landed for 2.16

          pjones Peter Jones added a comment - Landed for 2.16

          "Oleg Drokin <green@whamcloud.com>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/49160/
          Subject: LU-16313 pcc: use two bits to indicate pcc type for attach
          Project: fs/lustre-release
          Branch: master
          Current Patch Set:
          Commit: 6e90974b1f4ac24c5a5d45ecc9bdb4d47018dab4

          gerrit Gerrit Updater added a comment - "Oleg Drokin <green@whamcloud.com>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/49160/ Subject: LU-16313 pcc: use two bits to indicate pcc type for attach Project: fs/lustre-release Branch: master Current Patch Set: Commit: 6e90974b1f4ac24c5a5d45ecc9bdb4d47018dab4

          "Qian Yingjin <qian@ddn.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/49160
          Subject: LU-16313 pcc: use two bits to indicate pcc type for attach
          Project: fs/lustre-release
          Branch: master
          Current Patch Set: 1
          Commit: 05625e9774fac05ea1cf00f32637539fca1f966e

          gerrit Gerrit Updater added a comment - "Qian Yingjin <qian@ddn.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/49160 Subject: LU-16313 pcc: use two bits to indicate pcc type for attach Project: fs/lustre-release Branch: master Current Patch Set: 1 Commit: 05625e9774fac05ea1cf00f32637539fca1f966e

          People

            qian_wc Qian Yingjin
            qian_wc Qian Yingjin
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: