[LU-16412] check truncated page in ->read page()

• Type: Bug
• Resolution: Fixed
• Priority: Minor
• Fix Version/s: Lustre 2.16.0, Lustre 2.15.3
• Severity: 3
• Assignee: Qian Yingjin
• Reporter: Qian Yingjin

Description

I found the page end offset calculation in filemap_get_read_batch() was off by one in 5.x kernel.

When a read is submitted with end offset 1048575, then it incorrectly calculates
the end page for read of 1024 when it should be 1023. This result in the readpage() call of the page is over stripe boundary and may be not covered by a DLM extent lock.

In some corner racer case, filemap_get_read_batch() batches the page with index 1024 for read, but later this page is truncated and removed from page cache due to the lock protected it being revoked. This results in this page in the read path is not covered by a DLM lock. This will trigger an assertion in the code:

LustreError: 14129:0:(osc_object.c:397:osc_req_attr_set()) uncovered page!
Pid: 14129, comm: ptlrpcd_04_18 5.14.0-1038-oem #42-Ubuntu SMP Thu May 19 05:03:08 UTC 2022
LustreError: 14129:0:(osc_object.c:411:osc_req_attr_set()) LBUG

To work around this bug in the kernel, we can simply check whether this page got truncated and was removed from page cache in ->readpage(), and return AOP_TRUNCATED_PAGE to the upper layer, and then it will retry to batch pages and it will not add this truncated page into batches as it was removed from page cache.

Issue Links

• is duplicated by: LU-16638 LustreError: 18531:0:(osc_object.c:410:osc_req_attr_set()) LBUG
• is related to: LU-16579 llite: Fix the wrong ending offset calculation

Comments

[Gerrit Updater]

"Oleg Drokin <[e-mail]>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/50277/
Subject: LU-16412 llite: check read page past requested
Project: fs/lustre-release
Branch: b2_15
Current Patch Set:
Commit: c6388ef80ff593936296f394a0154729578ac6eb

[Gerrit Updater]

"Andreas Dilger <[e-mail]>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/50277
Subject: LU-16412 llite: check read page past requested
Project: fs/lustre-release
Branch: b2_15
Current Patch Set: 1
Commit: 3c35c311211e561dd83b665f081e0112044de98a

[Andreas Dilger]

Patch for the upstream kernel submitted:
https://lore.kernel.org/linux-fsdevel/[e-mail]/

Accepted into kernel and nackported to 6.1 and 5.15 stable trees:
https://lore.kernel.org/stable/[e-mail]/
https://lore.kernel.org/stable/[e-mail]/

This patch also ends up improving fxmark benchmark performance by 13%, likely due to avoiding extraneous reads of pages not actually requested by the application:
https://lore.kernel.org/linux-fsdevel/[e-mail]/