[LU-16565] Remove ldlm flag ldlm_{is,set,clear} macros

• Type: Improvement
• Resolution: Unresolved
• Priority: Minor
• Assignee: Patrick Farrell
• Reporter: Patrick Farrell

Description

We have macros like ldlm_{is,set,clear}_#FLAG_NAME# for all of the ldlm flags.  I'm going to remove them and convert all usages to just using the flag bit names directly.

They make it much harder to find all uses of the actual lock flags and we are entirely inconsistent on whether we use the macros or not.  And since we're always going to use the flag names for multi-flag uses, we can't convert 100% to macros anyway.

Comments

[Gerrit Updater]

"Oleg Drokin <[e-mail]>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/50030/
Subject: LU-16565 ldlm: Add ldlm_is,set,clear to spelling
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 9d5d5c72b7b8665236fedb66f34d973e239cb03c

[Gerrit Updater]

"Oleg Drokin <[e-mail]>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/57549/
Subject: LU-16565 ldlm: [2] Remove ldlm is,set,clear macros
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 6a9340d744fc5ccc250909b497eb18a43a885339

[Gerrit Updater]

"Oleg Drokin <[e-mail]>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/57547/
Subject: LU-16565 mdc: Remove ldlm is,set,clear macros
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: f718723bc62ae1a83a2629c10d92fbd8409f7e05

[Gerrit Updater]

"Oleg Drokin <[e-mail]>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/57545/
Subject: LU-16565 mdt: Remove ldlm is,set,clear macros
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: af4b4b59f93b5300232a961c5be1b1807d5e6729

[Gerrit Updater]

"Oleg Drokin <[e-mail]>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/57544/
Subject: LU-16565 osc: Remove ldlm is,set,clear macros
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 832fb0e2b18f7ffe6318695612e90d2bf77e1a16

[Gerrit Updater]

"Oleg Drokin <[e-mail]>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/57543/
Subject: LU-16565 quota: Remove ldlm is,set,clear macros
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 62eac36b7c9390f2696b3b29a990416ccfe29785

[Gerrit Updater]

"Oleg Drokin <[e-mail]>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/57542/
Subject: LU-16565 target: Remove ldlm is,set,clear macros
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 475a1ba0769c96c20024b62fc32e02064e534cec

[James A Simmons]

Yes I agree it would be better to use the atomic bit operations instead.

[Tim Day]

After refreshing this, I wonder if I should be using the atomic bit operations instead i.e. set_bit, clear_bit, and so on.

[Gerrit Updater]

"Timothy Day <[e-mail]>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/57550
Subject: LU-16565 ldlm: [3] Remove ldlm is,set,clear macros
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: d7af7113c0ff5f2065b07ee1295d91fdf331c660