Uploaded image for project: 'Lustre'
  1. Lustre
  2. LU-16599

clearing jobstats should match output format

Details

    • Improvement
    • Resolution: Fixed
    • Minor
    • Lustre 2.16.0
    • None
    • None
    • 9223372036854775807

    Description

      With the escaping of special characters in patch https://review.whamcloud.com/37764 "LU-11407 tgt: cleanup job_stats output printing" and truncation of log JobIds in patch https://review.whamcloud.com/49351 "LU-16376 obdclass: NUL terminate long jobid strings" it may be that the requested "clear" of a specific JobID in lprocfs_jobstats_seq_write(), considering that the format printed via "lctl get_param ..job_stats" does not match the internal name stored for the job.

      The written JobID to clear should be de-quoted, un-escaped and then truncated to match the 32-char JobID that is stored internally in ojs_hash.

      Attachments

        Issue Links

          is related to

          Bug - A problem which impairs or prevents the functions of the product. LU-16376 lprocfs_job_stats_log() Invalid jobid size (37), expect(32)

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Resolved

          Improvement - An improvement or enhancement to an existing feature or task. LU-11407 Improve stats data

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Resolved

          Activity

            [LU-16599] clearing jobstats should match output format
            pjones Peter Jones made changes -
            Fix Version/s New: Lustre 2.16.0 [ 15190 ]
            Resolution New: Fixed [ 1 ]
            Status Original: Open [ 1 ] New: Resolved [ 5 ]
            pjones Peter Jones added a comment -

            Landed for 2.16

            pjones Peter Jones added a comment - Landed for 2.16
            gerrit Gerrit Updater added a comment -

            "Oleg Drokin <green@whamcloud.com>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/50160/
            Subject: LU-16599 obdclass: job_stats can parse escaped jobid string
            Project: fs/lustre-release
            Branch: master
            Current Patch Set:
            Commit: 8f004bc53b1a488dad5a92a580f5f0c078e33654

            gerrit Gerrit Updater added a comment - "Oleg Drokin <green@whamcloud.com>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/50160/ Subject: LU-16599 obdclass: job_stats can parse escaped jobid string Project: fs/lustre-release Branch: master Current Patch Set: Commit: 8f004bc53b1a488dad5a92a580f5f0c078e33654
            gerrit Gerrit Updater added a comment -

            "Feng Lei <flei@whamcloud.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/50160
            Subject: LU-16599 obdclass: job_stats can parse escaped jobid string
            Project: fs/lustre-release
            Branch: master
            Current Patch Set: 1
            Commit: 7a563c6094f80d5c9facb085590d7a3d838adc75

            gerrit Gerrit Updater added a comment - "Feng Lei <flei@whamcloud.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/50160 Subject: LU-16599 obdclass: job_stats can parse escaped jobid string Project: fs/lustre-release Branch: master Current Patch Set: 1 Commit: 7a563c6094f80d5c9facb085590d7a3d838adc75
            flei Feng Lei made changes -
            Summary Original: clearning jobstats should match output format New: clearing jobstats should match output format
            adilger Andreas Dilger made changes -
            Description Original: With the escaping of special characters in patch https://review.whamcloud.com/37764 "{{LU-11407 tgt: cleanup job_stats output printing}}" and truncation of log JobIds in patch https://review.whamcloud.com/49351 "{{LU-16376 obdclass: NUL terminate long jobid strings}}" it may be that the requested "clear" of a specific JobID in {{lprocfs_jobstats_seq_write()}}, considering that the format printed via "{{lctl get_param *.*.job_stats}}" does not match the internal name stored for the job.

            The written JobID to clear should be un-escaped and then truncated to match the 32-char JobID that is stored internally in {{ojs_hash}}.             		New: With the escaping of special characters in patch https://review.whamcloud.com/37764 "{{LU-11407 tgt: cleanup job_stats output printing}}" and truncation of log JobIds in patch https://review.whamcloud.com/49351 "{{LU-16376 obdclass: NUL terminate long jobid strings}}" it may be that the requested "clear" of a specific JobID in {{lprocfs_jobstats_seq_write()}}, considering that the format printed via "{{lctl get_param *.*.job_stats}}" does not match the internal name stored for the job.

            The written JobID to clear should be de-quoted, un-escaped and then truncated to match the 32-char JobID that is stored internally in {{ojs_hash}}.
            adilger Andreas Dilger made changes -
            Link New: This issue is related to LU-16376 [ LU-16376 ]
            adilger Andreas Dilger made changes -
            Link New: This issue is related to LU-11407 [ LU-11407 ]
            adilger Andreas Dilger created issue -

            People

              flei Feng Lei
              adilger Andreas Dilger
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: