[LU-16620] OBD_FAIL_MDS_OPEN_WAIT_CREATE is not checked

• Type: Bug
• Resolution: Unresolved
• Priority: Minor
• Severity: 3
• Assignee: WC Triage
• Reporter: Alex Zhuravlev

Description

OBD_FAIL_MDS_OPEN_WAIT_CREATE is not used in the code, but replay-single/84 still uses that:

test_84a() {
#define OBD_FAIL_MDS_OPEN_WAIT_CREATE  0x144
    do_facet $SINGLEMDS "lctl set_param fail_loc=0x80000144"
    createmany -o $DIR/$tfile- 1 &
    PID=$!
    mds_evict_client

originally it was a delay in mdd_lov_create(), years ago:

@@ -457,6 +457,7 @@ int mdd_lov_create(const struct lu_env *env, struct mdd_device *mdd,
                                 GOTO(out_oti, rc);
                 }
 
+                OBD_FAIL_TIMEOUT(OBD_FAIL_MDS_OPEN_WAIT_CREATE, 10);
                 rc = obd_create(lov_exp, oa, &lsm, oti);

now createmany executes immediately and sometimes it's fast enough to complete before the evction. then subsequent 85a fails observing the evction.