[LU-16634] Null pointer dereference in lustre_set_wire_obdo

• Type: Bug
• Resolution: Fixed
• Priority: Critical
• Fix Version/s: Lustre 2.16.0

Environment

Lustre commit: 9ddcdee2c8b9ec14986b93cf3180d946cd4869f7


Three server nodes and one client. Kernel version: Ubuntu-5.4.0-90.101

# MGS
mkfs.lustre --fsname=lustre --mgs /dev/vda
mount -t lustre /dev/vda /root/lustre-server

# MDS
mkfs.lustre --fsname=lustre --index=0 --mgsnode=$start_ip@tcp0 --mdt /dev/vda
mount -t lustre /dev/vda /root/lustre-server

# OSS
mkfs.lustre --ost --fsname=lustre --index=1 --reformat --mgsnode=$start_ip@tcp0 /dev/vda
mount -t lustre /dev/vda /root/lustre-server

# Client
mount -t lustre $start_ip@tcp0:/lustre /root/lustre-client

• Severity: 3
• Assignee: Andreas Dilger
• Reporter: Tao Lyu

Description

[ 279.518552] kasan: GPF could be caused by NULL-ptr deref or user memory access
[ 279.520881] general protection fault: 0000 1 SMP KASAN NOPTI
[ 279.523366] CPU: 1 PID: 555 Comm: test Tainted: G O 5.4.148+ #7
[ 279.527232] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.15.0-1 04/01/2014
[ 279.530776] RIP: 0010:lustre_set_wire_obdo+0x7e/0x570 [obdclass]
[ 279.556223] Call Trace:
[ 279.556666] osc_getattr+0x1eb/0x950 [osc]
[ 279.558046] osc_iocontrol+0x4f1/0xe80 [osc]
[ 279.559241] lov_iocontrol+0x4ba/0x5de0 [lov]
[ 279.567254] ll_dir_ioctl+0x2834/0x17cc0 [lustre]
[ 279.590353] do_vfs_ioctl+0x405/0x660
[ 279.590784] ksys_ioctl+0x5e/0x90

Issue Links

• is related to: LU-16616 crash in osc_brw_prep_request() ASSERTION( page_count == 1 || (ergo(i == 0, poff + pg->count == PAGE_SIZE) ...
• is related to: LU-16617 A null-pointer dereference in osc_request.c:3358:function osc_iocontro
• is related to: LU-16688 Client crash due to an assertion in lite_lib.c:3394
• is related to: LU-12613 Lustre lustre_msg_string() bug
• is related to: LU-13107 clean up lctl commands

Comments

[Gerrit Updater]

"Oleg Drokin <[e-mail]>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/51596/
Subject: LU-16634 build: remove obsolete checkpatch strings
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: cf50755cce8b19c9cbfb20c12137b0eb3c3b66da

[Gerrit Updater]

"Andreas Dilger <[e-mail]>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/51596
Subject: LU-16634 build: remove obsolete checkpatch strings
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 4566b6d452f2ccc6b89c23b1865f3a5b5d0b2038

[Peter Jones]

All patches seem to have landed for 2.16

[Gerrit Updater]

"Oleg Drokin <[e-mail]>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/50390/
Subject: LU-16634 misc: replace obsolete ioctl numbers
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 594b780062db7e015837faefa75f7352293f54ae

[Gerrit Updater]

"Oleg Drokin <[e-mail]>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/50314/
Subject: LU-16634 misc: standardize iocontrol param handling
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 5eae8514f5f1730fe93d55d348400f5ecf681078

[Andreas Dilger]

tao.lyu, have you been able to validate that the provided patch (or the latest patch https://review.whamcloud.com/50314 on master) fixes the issue reported here and in LU-16617?

[Gerrit Updater]

"Oleg Drokin <[e-mail]>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/50335/
Subject: LU-16634 llite: move common ioctl code to ll_iocontrol()
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 3be425883918528ef981af697b34de187c3937b3

[Gerrit Updater]

"Oleg Drokin <[e-mail]>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/50334/
Subject: LU-16634 obdclass: improve iocontrol error messages
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 1f4825eff026321a8e769739868d4d482026c3ee

[Gerrit Updater]

"Oleg Drokin <[e-mail]>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/50333/
Subject: LU-16634 misc: remove unnecessary ioctl typecasts
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 4a1465577e1310ce09834103f7136bef0e1a1eeb

[Gerrit Updater]

"Oleg Drokin <[e-mail]>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/50331/
Subject: LU-16634 build: improve checkpatch warnings
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: fe13a1b01c61801065571b4049e8c6bd544742b7