[LU-16634] Null pointer dereference in lustre_set_wire_obdo

• Type: Bug
• Resolution: Fixed
• Priority: Critical
• Fix Version/s: Lustre 2.16.0

Environment

Lustre commit: 9ddcdee2c8b9ec14986b93cf3180d946cd4869f7


Three server nodes and one client. Kernel version: Ubuntu-5.4.0-90.101

# MGS
mkfs.lustre --fsname=lustre --mgs /dev/vda
mount -t lustre /dev/vda /root/lustre-server

# MDS
mkfs.lustre --fsname=lustre --index=0 --mgsnode=$start_ip@tcp0 --mdt /dev/vda
mount -t lustre /dev/vda /root/lustre-server

# OSS
mkfs.lustre --ost --fsname=lustre --index=1 --reformat --mgsnode=$start_ip@tcp0 /dev/vda
mount -t lustre /dev/vda /root/lustre-server

# Client
mount -t lustre $start_ip@tcp0:/lustre /root/lustre-client

• Severity: 3
• Assignee: Andreas Dilger
• Reporter: Tao Lyu

Description

[ 279.518552] kasan: GPF could be caused by NULL-ptr deref or user memory access
[ 279.520881] general protection fault: 0000 1 SMP KASAN NOPTI
[ 279.523366] CPU: 1 PID: 555 Comm: test Tainted: G O 5.4.148+ #7
[ 279.527232] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.15.0-1 04/01/2014
[ 279.530776] RIP: 0010:lustre_set_wire_obdo+0x7e/0x570 [obdclass]
[ 279.556223] Call Trace:
[ 279.556666] osc_getattr+0x1eb/0x950 [osc]
[ 279.558046] osc_iocontrol+0x4f1/0xe80 [osc]
[ 279.559241] lov_iocontrol+0x4ba/0x5de0 [lov]
[ 279.567254] ll_dir_ioctl+0x2834/0x17cc0 [lustre]
[ 279.590353] do_vfs_ioctl+0x405/0x660
[ 279.590784] ksys_ioctl+0x5e/0x90

Issue Links

• is related to: LU-16616 crash in osc_brw_prep_request() ASSERTION( page_count == 1 || (ergo(i == 0, poff + pg->count == PAGE_SIZE) ...
• is related to: LU-16617 A null-pointer dereference in osc_request.c:3358:function osc_iocontro
• is related to: LU-16688 Client crash due to an assertion in lite_lib.c:3394
• is related to: LU-12613 Lustre lustre_msg_string() bug
• is related to: LU-13107 clean up lctl commands

Comments

[Gerrit Updater]

"Oleg Drokin <[e-mail]>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/50333/
Subject: LU-16634 misc: remove unnecessary ioctl typecasts
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 4a1465577e1310ce09834103f7136bef0e1a1eeb

[Gerrit Updater]

"Oleg Drokin <[e-mail]>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/50331/
Subject: LU-16634 build: improve checkpatch warnings
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: fe13a1b01c61801065571b4049e8c6bd544742b7

[Gerrit Updater]

"Andreas Dilger <[e-mail]>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/50390
Subject: LU-16634 misc: replace obsolete ioctl numbers
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 882314ade0a2b51f3b119ac71d5c1841e48571f1

[Gerrit Updater]

"Andreas Dilger <[e-mail]>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/50335
Subject: LU-16634 llite: move common ioctl code to ll_iocontrol()
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 0609508786a8192e6fa691f632433ee71b209eee

[Gerrit Updater]

"Andreas Dilger <[e-mail]>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/50334
Subject: LU-16634 obdclass: improve iocontrol error messages
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 08517e8ffb81f2a3092057d4f905afd8e224bc6f

[Gerrit Updater]

"Andreas Dilger <[e-mail]>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/50333
Subject: LU-16634 misc: remove unnecessary ioctl typecasts
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 2dfbbce062dfcfa7e08d1fe6f7745ba2ced0a6b0

[Gerrit Updater]

"Andreas Dilger <[e-mail]>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/50331
Subject: LU-16634 build: improve checkpatch warnings
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: b0b4408491d1414848db289c594524a58cffddba

[Tao Lyu]

Thanks, I'll test it later and reply you.

Could you please take a look at another two issues I reported:
LU-16617
LU-16616

Thanks!

[Andreas Dilger]

PS: I will add "Reported-by: Tao Lyu <[e-mail]>" in the updated version of the patch.

[Andreas Dilger]

Hello tao.lyu, I've created a patch that should address the class of issues that you uncovered. The Gerrit link is above, and I will also attach the current version of the patch against the master branch to this ticket.

There is one cosmetic defect in the current version that is causing regression test failures (returning -EINVAL instead of -ENOTTY in one test case), but it should be ok for your testing.

Please let me know if this resolved the issue you hit. Once it has been reviewed and passes regression testing the patch will be landed to master and backpirted to the maintenance branches.

Please file a separate Jira ticket you uncover other unrelated issues.

[Gerrit Updater]

"Andreas Dilger <[e-mail]>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/50314
Subject: LU-16634 misc: standardize handling of ioctl params
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 496b2b5190703ae6cec88568a6837f0347185fd9