[LU-16656] Improve location of 'out:' in ll_file_io_generic - Whamcloud Community JIRA

Details

Type: Improvement
Resolution: Unresolved
Priority: Minor
Fix Version/s: None
Affects Version/s: None
Labels:
None

Rank (Obsolete):
9223372036854775807

Description

The location of the 'out:' label in ll_file_io_generic is a bit scary, because it skips part of the setup for io_restart, where partial io is taken in to account. This is safe today because 'out:' is only used before calls to cl_io_loop, so a partial IO is impossible, but if 'out;' is ever used later in the function, it will be incorrect. Let's move it now rather than leave a trap for the unwary.

Attachments

Activity

[LU-16656] Improve location of 'out:' in ll_file_io_generic

Gerrit Updater added a comment - 22/Mar/23 5:34 PM

"Patrick Farrell <pfarrell@whamcloud.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/50379
Subject: LU-16656 llite: Improve 'out:' in ll_file_io_generic
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: cbb66bdc44a9f7631abf31502da233a9b402d7d9

Gerrit Updater added a comment - 22/Mar/23 5:34 PM "Patrick Farrell <pfarrell@whamcloud.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/50379 Subject: LU-16656 llite: Improve 'out:' in ll_file_io_generic Project: fs/lustre-release Branch: master Current Patch Set: 1 Commit: cbb66bdc44a9f7631abf31502da233a9b402d7d9

People

Assignee:: Patrick Farrell

Reporter:: Patrick Farrell

Votes:: 0 Vote for this issue

Watchers:: 2 Start watching this issue

Dates

Created:: 22/Mar/23 5:31 PM

Updated:: 22/Mar/23 5:34 PM