[LU-16709] LNet: locking multiple NIDs of the same MR peer as primary results in incorrect representation

• Type: Bug
• Resolution: Fixed
• Priority: Minor
• Fix Version/s: Lustre 2.16.0, Lustre 2.15.5
• Labels: lnet multi-rail
• Severity: 3
• Assignee: Serguei Smirnov
• Reporter: Serguei Smirnov

Description

System configurations which result in Lustre layer specifying the same MR peer using multiple NIDs cause an issue with primary NID locking logic: when "primary nid locking" feature is enabled, LNet creates separate peer records, each record containing one NID of the MR peer as "locked primary". After the discovery completes in the background, these records are not being merged. This results in incorrect peer representation. Here's an example:

server:

# lnetctl net show
net:
    - net type: lo
      local NI(s):
        - nid: 0@lo
          status: up
    - net type: tcp
      local NI(s):
        - nid: 192.168.122.50@tcp
          status: up
          interfaces:
              0: eth0
        - nid: 192.168.122.134@tcp
          status: up
          interfaces:
              0: ens12

client:

# mount -t lustre 192.168.122.134@tcp:192.168.122.50@tcp:/lustrewt /mnt/lustrefs
# lnetctl peer show 
peer:
    - primary nid: 192.168.122.134@tcp
      Multi-Rail: True
      peer ni:
        - nid: 192.168.122.134@tcp
          state: NA
    - primary nid: 192.168.122.50@tcp
      Multi-Rail: True
      peer ni:
        - nid: 192.168.122.50@tcp
          state: NA

Comments

[Gerrit Updater]

"Oleg Drokin <[e-mail]>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/55486/
Subject: LU-16709 lnet: fix locking multiple NIDs of the MR peer
Project: fs/lustre-release
Branch: b2_15
Current Patch Set:
Commit: 55f82ea129035cd64832be11f24821fd5f1b80f9

[Peter Jones]

Thanks Chris!

[Gerrit Updater]

"Frederick Dilger <[e-mail]>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/55486
Subject: LU-16709 lnet: fix locking multiple NIDs of the MR peer
Project: fs/lustre-release
Branch: b2_15
Current Patch Set: 1
Commit: 79e4133f30e924ad552e9e8a53662c65c14476f6

[Serguei Smirnov]

hornc, yes I agree this patch should be backported too. I'll take care of this.

[Chris Horn]

ssmirnov pjones is this patch needed in b2_15 since the LU-14668 patch series was backported there?

[Peter Jones]

Seems to have merged for 2.16

[Gerrit Updater]

"Oleg Drokin <[e-mail]>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/50530/
Subject: LU-16709 lnet: fix locking multiple NIDs of the MR peer
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 3b7a02ee4d656b7b3e044713681da2f56dddb152