Uploaded image for project: 'Lustre'
  1. Lustre
  2. LU-16828

build find cmdline correctly for sanity test_133g

Details

    • Bug
    • Resolution: Fixed
    • Major
    • Upstream, Lustre 2.16.0
    • None
    • None
    • 3
    • 9223372036854775807

    Description

      The following huge output of test_133g is not correct. It means "find" does not include its "-name $PARAM" argument.

       

      == sanity test 133g: Check reads/writes of server lustre proc files with bad area io ========================================================== 16:13:38 (1683821618)
      CMD: onyx-103vm7 /usr/sbin/lctl get_param -n version 2>/dev/null
      CMD: onyx-103vm7 /usr/sbin/lctl list_param -FR '*' | grep '=' |
      tr -d = | egrep -v 'force_lbug|changelog_mask|daemon_file' |
      xargs -n 1 find /proc/fs/lustre/
      /sys/fs/lustre/
      /sys/kernel/debug/lnet/
      /sys/kernel/debug/lustre/ -name |
      xargs -n 1 badarea_io
      onyx-103vm7: find: 'at_early_margin': No such file or directory
      onyx-103vm7: find: 'at_extra': No such file or directory
      /proc/fs/lustre/
      /proc/fs/lustre/lmv
      /proc/fs/lustre/lod
      /proc/fs/lustre/lod/lustre-MDT0000-mdtlov
      /proc/fs/lustre/lod/lustre-MDT0000-mdtlov/pool
      /proc/fs/lustre/lod/lustre-MDT0000-mdtlov/pools
      /proc/fs/lustre/lod/lustre-MDT0000-mdtlov/mdt_obd
      /proc/fs/lustre/lod/lustre-MDT0000-mdtlov/target_obd
      /proc/fs/lustre/lov
      /proc/fs/lustre/lov/lustre-MDT0000-mdtlov
      /proc/fs/lustre/mdc
      /proc/fs/lustre/mdt
      /proc/fs/lustre/mdt/lustre-MDT0000
      /proc/fs/lustre/mdt/lustre-MDT0000/exports
      /proc/fs/lustre/mdt/lustre-MDT0000/exports/0@lo
      /proc/fs/lustre/mdt/lustre-MDT0000/exports/0@lo/hash
      /proc/fs/lustre/mdt/lustre-MDT0000/exports/0@lo/uuid
      /proc/fs/lustre/mdt/lustre-MDT0000/exports/0@lo/stats
      /proc/fs/lustre/mdt/lustre-MDT0000/exports/0@lo/export
      

       

      # proc_regexp="/\{proc,sys}/\{fs,sys,kernel/debug}/\{lustre,lnet}/"
      # proc_dirs=$(eval ls -d $proc_regexp)
      
      

       

      After running the upper commands, 'echo "$proc_dirs"' woud print
      multiple lines like what sanity test 401a would print:

      proc_dirs='/proc/fs/lustre/
      /sys/fs/lustre/
      /sys/kernel/debug/lnet/
      /sys/kernel/debug/lustre/'
      
      

      Attachments

        Issue Links

          Activity

            [LU-16828] build find cmdline correctly for sanity test_133g
            pjones Peter Jones added a comment -

            Landed for 2.16

            pjones Peter Jones added a comment - Landed for 2.16

            "Oleg Drokin <green@whamcloud.com>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/50994/
            Subject: LU-16828 sanity: wrong argument for find in test_133g
            Project: fs/lustre-release
            Branch: master
            Current Patch Set:
            Commit: 03c75f99e6ca4b445cefbc446b033da952d758e4

            gerrit Gerrit Updater added a comment - "Oleg Drokin <green@whamcloud.com>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/50994/ Subject: LU-16828 sanity: wrong argument for find in test_133g Project: fs/lustre-release Branch: master Current Patch Set: Commit: 03c75f99e6ca4b445cefbc446b033da952d758e4
            lixi_wc Li Xi added a comment -

            Andreas's patch might have already fixed this together (I am not sure): https://review.whamcloud.com/c/fs/lustre-release/+/46156

            lixi_wc Li Xi added a comment - Andreas's patch might have already fixed this together (I am not sure): https://review.whamcloud.com/c/fs/lustre-release/+/46156

            "Li Xi <lixi@ddn.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/50994
            Subject: LU-16828 sanity: wrong argument for find in test_133g
            Project: fs/lustre-release
            Branch: master
            Current Patch Set: 1
            Commit: c71634c50cdf136ff4535f162e01a337e369212e

            gerrit Gerrit Updater added a comment - "Li Xi <lixi@ddn.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/50994 Subject: LU-16828 sanity: wrong argument for find in test_133g Project: fs/lustre-release Branch: master Current Patch Set: 1 Commit: c71634c50cdf136ff4535f162e01a337e369212e

            People

              lixi_wc Li Xi
              lixi_wc Li Xi
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: