[LU-17010] lfsck_trans_create shouldn't be called in dryrun mode

• Type: Bug
• Resolution: Fixed
• Priority: Major
• Fix Version/s: Lustre 2.16.0
• Affects Version/s: Lustre 2.16.0, Lustre 2.15.3, Lustre 2.15.5
• Severity: 3
• Assignee: Hongchao Zhang
• Reporter: Hongchao Zhang

Description

When running LFSCK with --dryrun the following stack will spam the console log while running and cause significant load/slowdown on the MDT due to the many console messages:

kernel: CPU: 8 PID: 21324 Comm: lfsck Tainted: G OE ------------ T 3.10.0-1160.59.1.el7_lustre.ddn16.x86_64 #1
kernel: Hardware name: DDN SFA400NVXE, BIOS rel-1.14.0-0-g155821a1990b-prebuilt.qemu.org 04/01/2014
kernel: Call Trace:
kernel: [<ffffffff9d3865b9>] dump_stack+0x19/0x1b
kernel: [<ffffffffc133e164>] lfsck_trans_create.part.53+0x6c/0x75 [lfsck]
kernel: [<ffffffffc1302d39>] lfsck_namespace_trace_update+0x919/0xa10 [lfsck]
kernel: [<ffffffffc0611f02>] ? fld_local_lookup+0x62/0x270 [fld]
kernel: [<ffffffffc1307d60>] lfsck_namespace_exec_oit+0x6b0/0x880 [lfsck]
kernel: [<ffffffffc12f0871>] lfsck_exec_oit+0x81/0xb10 [lfsck]
kernel: [<ffffffffc12f1ae8>] lfsck_master_oit_engine+0x7e8/0x12f0 [lfsck]
kernel: [<ffffffff9cce6321>] ? put_prev_entity+0x31/0x400
kernel: [<ffffffffc12f2ee6>] lfsck_master_engine+0x8f6/0x13b0 [lfsck]
kernel: [<ffffffff9ccd4abe>] ? finish_task_switch+0x4e/0x1c0
kernel: [<ffffffff9ccdadf0>] ? wake_up_state+0x20/0x20
kernel: [<ffffffffc12f25f0>] ? lfsck_master_oit_engine+0x12f0/0x12f0 [lfsck]
kernel: [<ffffffff9ccc5e61>] kthread+0xd1/0xe0
kernel: [<ffffffff9ccc5d90>] ? insert_kthread_work+0x40/0x40
kernel: [<ffffffff9d399ddd>] ret_from_fork_nospec_begin+0x7/0x21
kernel: [<ffffffff9ccc5d90>] ? insert_kthread_work+0x40/0x40
kernel: CPU: 8 PID: 21324 Comm: lfsck Tainted: G OE ------------ T 3.10.0-1160.59.1.el7_lustre.ddn16.x86_64 #1

Issue Links

• is related to: LU-13124 lfsck check for multiple linked file at OST

Comments

[Gerrit Updater]

"Oleg Drokin <[e-mail]>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/54853/
Subject: LU-17010 lfsck: don't dump stack repeatedly
Project: fs/lustre-release
Branch: b2_15
Current Patch Set:
Commit: 1d54befc9bc69188092dc4ef18d301c43b9ca8cd

[Gerrit Updater]

"Xing Huang <[e-mail]>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/54853
Subject: LU-17010 lfsck: don't dump stack repeatedly
Project: fs/lustre-release
Branch: b2_15
Current Patch Set: 1
Commit: 3df146dac296135860fb101d13d7ddcbc895df50

[Gerrit Updater]

"Oleg Drokin <[e-mail]>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/52356/
Subject: LU-17010 lfsck: don't dump stack repeatedly
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: dc360cd3eff20618f243ab89097a62f8ecf2c929

[Gerrit Updater]

"Andreas Dilger <[e-mail]>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/52356
Subject: LU-17010 lfsck: don't dump stack repeatedly
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: c4d8c5439c74fe71bc8c3f940bf259d00ed25753

[Peter Jones]

Landed for 2.16

[Gerrit Updater]

"Oleg Drokin <[e-mail]>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/51849/
Subject: LU-17010 lfsck: don't create trans in dryrun mode
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 441902fa3d445791a8c54026c130ab357f7469d7

[Gerrit Updater]

"Hongchao Zhang <[e-mail]>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/51849
Subject: LU-17010 lfsck: don't create trans in dryrun mode
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: b0de6c377e4ee57a5d1af8db82958c8afe43db3b