Uploaded image for project: 'Lustre'
  1. Lustre
  2. LU-17062

Prevent use after free following *_decref_locked() usage

Details

    • 3
    • 9223372036854775807

    Description

      In rare cases when one of:
      lnet_peer_net_decref_locked
      lnet_peer_decref_locked
      lnet_peer_ni_decref_locked
      Actually destroys the object it is not safe to use.
      Update the functions to return true when the object is deleted and ensure the object is not referenced (used) after it has been kfree()'d.

      Attachments

        Issue Links

          is related to

          Bug - A problem which impairs or prevents the functions of the product. LU-18320 interop: sanity-lnet test_226: ASSERTION( list_empty(&lpni->lpni_peer_nis) ) failed

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Resolved

          Activity

            [LU-17062] Prevent use after free following *_decref_locked() usage
            gerrit Gerrit Updater added a comment -

            "Oleg Drokin <green@whamcloud.com>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/54904/
            Subject: LU-17062 lnet: Update lnet_peer_*_decref_locked usage
            Project: fs/lustre-release
            Branch: b2_15
            Current Patch Set:
            Commit: 2df49b78c86f9609e5a296bad02a1ecb600a3a7b

            gerrit Gerrit Updater added a comment - "Oleg Drokin <green@whamcloud.com>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/54904/ Subject: LU-17062 lnet: Update lnet_peer_*_decref_locked usage Project: fs/lustre-release Branch: b2_15 Current Patch Set: Commit: 2df49b78c86f9609e5a296bad02a1ecb600a3a7b
            gerrit Gerrit Updater added a comment -

            "Xing Huang <hxing@ddn.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/54904
            Subject: LU-17062 lnet: Update lnet_peer_*_decref_locked usage
            Project: fs/lustre-release
            Branch: b2_15
            Current Patch Set: 1
            Commit: 16664dccbd3046e938ab846e2867abd8250231b6

            gerrit Gerrit Updater added a comment - "Xing Huang <hxing@ddn.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/54904 Subject: LU-17062 lnet: Update lnet_peer_*_decref_locked usage Project: fs/lustre-release Branch: b2_15 Current Patch Set: 1 Commit: 16664dccbd3046e938ab846e2867abd8250231b6
            pjones Peter Jones added a comment -

            Landed for 2.16

            pjones Peter Jones added a comment - Landed for 2.16
            gerrit Gerrit Updater added a comment -

            "Oleg Drokin <green@whamcloud.com>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/52184/
            Subject: LU-17062 lnet: Update lnet_peer_*_decref_locked usage
            Project: fs/lustre-release
            Branch: master
            Current Patch Set:
            Commit: 60cfceb8c59364f786b31ac36c2c245b9a1e495a

            gerrit Gerrit Updater added a comment - "Oleg Drokin <green@whamcloud.com>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/52184/ Subject: LU-17062 lnet: Update lnet_peer_*_decref_locked usage Project: fs/lustre-release Branch: master Current Patch Set: Commit: 60cfceb8c59364f786b31ac36c2c245b9a1e495a
            gerrit Gerrit Updater added a comment -

            "Shaun Tancheff <shaun.tancheff@hpe.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/52184
            Subject: LU-17062 lnet: Update lnet_peer_*_decref_locked usage
            Project: fs/lustre-release
            Branch: master
            Current Patch Set: 1
            Commit: 3d0e75bcd073c52613644830319f99f73b9a3843

            gerrit Gerrit Updater added a comment - "Shaun Tancheff <shaun.tancheff@hpe.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/52184 Subject: LU-17062 lnet: Update lnet_peer_*_decref_locked usage Project: fs/lustre-release Branch: master Current Patch Set: 1 Commit: 3d0e75bcd073c52613644830319f99f73b9a3843

            People

              stancheff Shaun Tancheff
              stancheff Shaun Tancheff
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: