[LU-17166] add NRS TBF rule for projid

• Type: Improvement
• Resolution: Unresolved
• Priority: Minor
• Affects Version/s: Lustre 2.16.0
• Labels: easy
• Severity: 3
• Assignee: Etienne Aujames
• Reporter: Andreas Dilger

Description

It appears that there was no rule added for NRS TBF to allow selecting the project ID for an RPC.

Issue Links

• is related to: LU-19077 nodemap must map ptlrpc_body_v2/v3 pb_uid/pb_gid/pb_prjid fields
• is related to: LU-18179 Implementation of Round-Robin/Fair Share response with Token Bucket Filters
• is related to: LU-16007 NRS Jobid default RPC aggregation
• is related to: LU-17902 add NRS TBF policy for nodemap
• is related to: LU-18222 LQA: Implement quota aggregation limits by ID range
• is related to: LU-9658 Add QoS for uid and gid in NRS-TBF
• is related to: LU-18109 Nodemap UID/GID/PROJID idmap offsetting
• is related to: LU-18509 TBF: define a rule with a range of PROJID/UID/GID values

Comments

[Gerrit Updater]

"Oleg Drokin <[e-mail]>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/54920/
Subject: LU-17166 ptlrpc: add pb_projid field in ptlrpc_body
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 2cde8f434a86b8499dfbe56d59fe93a028c229ee

[Gerrit Updater]

"Qian Yingjin <[e-mail]>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/57245
Subject: LU-17166 nrs: add NRS TBF rule for ProjID support
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: be558146346fa11732260376a32542fd451c1b7a

[Qian Yingjin]

We have a patch for PCC implementing the similar functionality:

LU-13881 pcc: comparator support for PCC rules

https://review.whamcloud.com/c/fs/lustre-release/+/39585

TBF rule can borrow the code from PCC to define a rule with a range of PROJID values with '<' or '>' comparator.

 

We also have a patch for aggregate shared rate limiting for TBF:

https://review.whamcloud.com/#/c/fs/lustre-release/+/56351/

[Andreas Dilger]

Alternately (or in addition), would it be easier/better to use the TBF nodemap functionality described in LU-17902 to directly aggregate all RPCs from a given nodemap into one bucket rather than going through the indirection of using a nodemap range?

[Andreas Dilger]

eaujames, qian_wc, would the TBF rules allow (with the above addition of pb_projid to the RPC structure) restricting the RPC rate for a range of PROJID values? The patch https://review.whamcloud.com/55943 "LU-18109 utils: adding nodemap offset capability LU-18109" allows groups of clients in a nodemap to be assigned a range of UID/GID/PROJID values, and I'm wondering if the TBF rate limiting could be similarly used to aggregate a range of PROJID values into a single bucket so that they can be constrained to e.g. 10% of the storage bandwidth/IOPS, or similar?

[Gerrit Updater]

"Etienne AUJAMES <[e-mail]>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/54920
Subject: LU-17166 ptlrpc: add pb_projid field in ptlrpc_body
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 3404e9f4800cf8f730dae3e78a71ea622ca23496