Details
-
Improvement
-
Resolution: Unresolved
-
Minor
-
None
-
None
-
3
-
9223372036854775807
Description
The nrs_tbf_client structure is badly named. This might have represented the state of a single client for the original TBF implementation that was a node-based rate, but it no longer makes sense for the current TBF implementation that may have rate limits for UID/GID/JobID, etc.
It would be better to rename this as nrs_tbf_class or similar, and use "ntc" as the variable name instead of "cli".
There are also a number of functions related to this, like "nrs_tbf_cli_init()" that also need to be renamed.