Uploaded image for project: 'Lustre'
  1. Lustre
  2. LU-17195

Add option to dump log on checksum error

Details

    • Improvement
    • Resolution: Fixed
    • Minor
    • None
    • None
    • None
    • 3
    • 9223372036854775807

    Description

      Add an option to dump debug log on checksum failure. Similar to dump_on_eviction/timeout

      Attachments

        Issue Links

          Activity

            [LU-17195] Add option to dump log on checksum error
            hornc Chris Horn added a comment -

            I was mistaken. The existing checksum_dump feature already dumps the debug log, so this patch is redundant.

            hornc Chris Horn added a comment - I was mistaken. The existing checksum_dump feature already dumps the debug log, so this patch is redundant.
            hornc Chris Horn added a comment -

            AFAICT, the LU-8376 patch dumps the page content from the bulk xfer that failed the checksum. It does this on both client and server so that the content can be compared after the fact to see what has changed. My patch just dumps the lustre debug log to /tmp in the same manner as dump_on_eviction and dump_on_timeout. So I think these two patches are complimentary.

            hornc Chris Horn added a comment - AFAICT, the LU-8376 patch dumps the page content from the bulk xfer that failed the checksum. It does this on both client and server so that the content can be compared after the fact to see what has changed. My patch just dumps the lustre debug log to /tmp in the same manner as dump_on_eviction and dump_on_timeout. So I think these two patches are complimentary.

            Chris, how does this differ from the checksum_dump functionality added by patch https://review.whamcloud.com/23960 "LU-8376 ost: enhance end to end bulk cksum error report"? That will already dump the checksum data to a file when there is an error detected.

            adilger Andreas Dilger added a comment - Chris, how does this differ from the checksum_dump functionality added by patch https://review.whamcloud.com/23960 " LU-8376 ost: enhance end to end bulk cksum error report "? That will already dump the checksum data to a file when there is an error detected.

            "Chris Horn <chris.horn@hpe.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/52691
            Subject: LU-17195 obd: Add dump_on_checksum parameter
            Project: fs/lustre-release
            Branch: master
            Current Patch Set: 1
            Commit: e59ff6b4fb98e3e5b3f673bf09c5598b02ef343b

            gerrit Gerrit Updater added a comment - "Chris Horn <chris.horn@hpe.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/52691 Subject: LU-17195 obd: Add dump_on_checksum parameter Project: fs/lustre-release Branch: master Current Patch Set: 1 Commit: e59ff6b4fb98e3e5b3f673bf09c5598b02ef343b

            People

              hornc Chris Horn
              hornc Chris Horn
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: