Uploaded image for project: 'Lustre'
  1. Lustre
  2. LU-17463

enable/disable page cache shrinker for mlocked pages on OSC layer

Details

    • Bug
    • Resolution: Unresolved
    • Minor
    • None
    • None
    • None
    • 3
    • 9223372036854775807

    Description

      Those pages mapped into VM_LOCKED [mlock()ed] VMAs should be unevictable pages:
      i.e. mlocked pages via mlock() or mlockall() (see the URL for details: https://www.kernel.org/doc/html/v4.19/vm/unevictable-lru.html).

      However, OSC page cache shrinker treats all cached page equally even some of them are unelectable. It may evict the mlocked pages wrongly.

      We should disable page cache shrinker to avoid it evicting mlocked pages.

      Attachments

        Issue Links

          Activity

            [LU-17463] enable/disable page cache shrinker for mlocked pages on OSC layer

            Patch https://review.whamcloud.com/56637 "LU-18226 tests: allow small margin for unevicted pages" was landed as v2_16_0-RC2-2-gfda0fb235a to address the intermittent failures in test_600a.

            adilger Andreas Dilger added a comment - Patch https://review.whamcloud.com/56637 " LU-18226 tests: allow small margin for unevicted pages " was landed as v2_16_0-RC2-2-gfda0fb235a to address the intermittent failures in test_600a.

            The new sanity test_600a added by patch https://review.whamcloud.com/53826 "LU-17463 osc: add support for unevictable mlock()ed pages" is failing intermittently with "unevict_mb is 99, expected 100" :
            https://testing.whamcloud.com/search?status%5B%5D=FAIL&test_set_script_id=f9516376-32bc-11e0-aaee-52540025f9ae&sub_test_script_id=80fa812e-ebde-494c-9b7a-25ad76267630&start_date=2024-08-21&end_date=2024-09-02&source=sub_tests#redirect

            so it looks like the test is a bit flakey and needs to be fixed.

            adilger Andreas Dilger added a comment - The new sanity test_600a added by patch https://review.whamcloud.com/53826 " LU-17463 osc: add support for unevictable mlock()ed pages " is failing intermittently with " unevict_mb is 99, expected 100 " : https://testing.whamcloud.com/search?status%5B%5D=FAIL&test_set_script_id=f9516376-32bc-11e0-aaee-52540025f9ae&sub_test_script_id=80fa812e-ebde-494c-9b7a-25ad76267630&start_date=2024-08-21&end_date=2024-09-02&source=sub_tests#redirect so it looks like the test is a bit flakey and needs to be fixed.

            "Oleg Drokin <green@whamcloud.com>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/53826/
            Subject: LU-17463 osc: add support for unevictable mlock()ed pages
            Project: fs/lustre-release
            Branch: master
            Current Patch Set:
            Commit: 2a3ec2fea384355901e7888d1e043e82416518cb

            gerrit Gerrit Updater added a comment - "Oleg Drokin <green@whamcloud.com>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/53826/ Subject: LU-17463 osc: add support for unevictable mlock()ed pages Project: fs/lustre-release Branch: master Current Patch Set: Commit: 2a3ec2fea384355901e7888d1e043e82416518cb

            "Qian Yingjin <qian@ddn.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/55469
            Subject: LU-17463 llite: add a tunable parameter for mlocked page checking
            Project: fs/lustre-release
            Branch: master
            Current Patch Set: 1
            Commit: 0232e134b474d137212990fe307858f655358341

            gerrit Gerrit Updater added a comment - "Qian Yingjin <qian@ddn.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/55469 Subject: LU-17463 llite: add a tunable parameter for mlocked page checking Project: fs/lustre-release Branch: master Current Patch Set: 1 Commit: 0232e134b474d137212990fe307858f655358341

            "Oleg Drokin <green@whamcloud.com>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/53795/
            Subject: LU-17463 osc: add option to disable page cache shrinker
            Project: fs/lustre-release
            Branch: master
            Current Patch Set:
            Commit: d90ce0aab10ee8856140720cd71935da6877a5ab

            gerrit Gerrit Updater added a comment - "Oleg Drokin <green@whamcloud.com>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/53795/ Subject: LU-17463 osc: add option to disable page cache shrinker Project: fs/lustre-release Branch: master Current Patch Set: Commit: d90ce0aab10ee8856140720cd71935da6877a5ab

            "Qian Yingjin <qian@ddn.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/54292
            Subject: LU-17463 llite: put pages into unevict list inside mlock range
            Project: fs/lustre-release
            Branch: master
            Current Patch Set: 1
            Commit: a2a872ac9b779380e9afcfa7e45e4cda55aa7ec4

            gerrit Gerrit Updater added a comment - "Qian Yingjin <qian@ddn.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/54292 Subject: LU-17463 llite: put pages into unevict list inside mlock range Project: fs/lustre-release Branch: master Current Patch Set: 1 Commit: a2a872ac9b779380e9afcfa7e45e4cda55aa7ec4

            "Qian Yingjin <qian@ddn.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/54288
            Subject: LU-17463 osc: put read page into unevictable list earlierly
            Project: fs/lustre-release
            Branch: master
            Current Patch Set: 1
            Commit: ed72916cdbe33c6ff99a3a160faafb9d6b2ffc1c

            gerrit Gerrit Updater added a comment - "Qian Yingjin <qian@ddn.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/54288 Subject: LU-17463 osc: put read page into unevictable list earlierly Project: fs/lustre-release Branch: master Current Patch Set: 1 Commit: ed72916cdbe33c6ff99a3a160faafb9d6b2ffc1c

            "Qian Yingjin <qian@ddn.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/54218
            Subject: LU-17463 osc: scan the unevictable pages periodically
            Project: fs/lustre-release
            Branch: master
            Current Patch Set: 1
            Commit: 8d6495ccbb79406029e36b930b785c47c9984253

            gerrit Gerrit Updater added a comment - "Qian Yingjin <qian@ddn.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/54218 Subject: LU-17463 osc: scan the unevictable pages periodically Project: fs/lustre-release Branch: master Current Patch Set: 1 Commit: 8d6495ccbb79406029e36b930b785c47c9984253

            "Qian Yingjin <qian@ddn.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/53826
            Subject: LU-17463 osc: add support for unevitable mlock()ed pages
            Project: fs/lustre-release
            Branch: master
            Current Patch Set: 1
            Commit: 6c0213821095431a16ae36cddbaba7a02385cb3e

            gerrit Gerrit Updater added a comment - "Qian Yingjin <qian@ddn.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/53826 Subject: LU-17463 osc: add support for unevitable mlock()ed pages Project: fs/lustre-release Branch: master Current Patch Set: 1 Commit: 6c0213821095431a16ae36cddbaba7a02385cb3e

            "Qian Yingjin <qian@ddn.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/53795
            Subject: LU-17463 osc: add option to disable page cache shrinker
            Project: fs/lustre-release
            Branch: master
            Current Patch Set: 1
            Commit: c243a844e6d66fdb7aac86618c38e3e9457b8e68

            gerrit Gerrit Updater added a comment - "Qian Yingjin <qian@ddn.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/53795 Subject: LU-17463 osc: add option to disable page cache shrinker Project: fs/lustre-release Branch: master Current Patch Set: 1 Commit: c243a844e6d66fdb7aac86618c38e3e9457b8e68

            People

              qian_wc Qian Yingjin
              qian_wc Qian Yingjin
              Votes:
              0 Vote for this issue
              Watchers:
              13 Start watching this issue

              Dates

                Created:
                Updated: