[LU-17487] parsing --with-o2ib fails

• Type: Bug
• Resolution: Unresolved
• Priority: Minor
• Fix Version/s: Lustre 2.17.0
• Affects Version/s: Lustre 2.16.0
• Severity: 3
• Assignee: Shaun Tancheff
• Reporter: Shuichi Ihara

Description

commit "3c66185c84 LU-17398 build: detect mlnx-ofa_kernel-devel contents" still has a regression below.

# git clean -d -x -f ; sh ./autogen.sh; ./configure --with-o2ib=/usr/src/ofa_kernel/default; make rpms

- snip - 
Executing(%build): /bin/sh -e /tmp/rpmbuild-lustre-root-5bVhWL5I/TMP/rpm-tmp.dGQGBH
+ umask 022
+ cd /tmp/rpmbuild-lustre-root-5bVhWL5I/BUILD
+ cd lustre-2.15.60_12_g3c66185
+ cd /tmp/rpmbuild-lustre-root-5bVhWL5I/BUILD/lustre-2.15.60_12_g3c66185
+ export 'UTILS_CFLAGS=-O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -fexceptions -fstack-protector-strong -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection'
+ UTILS_CFLAGS='-O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -fexceptions -fstack-protector-strong -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection'
+ export 'UTILS_LDFLAGS=-Wl,-z,relro  -Wl,-z,now -specs=/usr/lib/rpm/redhat/redhat-hardened-ld'
+ UTILS_LDFLAGS='-Wl,-z,relro  -Wl,-z,now -specs=/usr/lib/rpm/redhat/redhat-hardened-ld'
+ CONFIGURE_ARGS=''\''--with-o2ib=/usr/src/ofa_kernel/default'\'''
+ '[' -n ''\''--with-o2ib=/usr/src/ofa_kernel/default'\''' ']'
++ echo ''\''--with-o2ib=/usr/src/ofa_kernel/default'\'''
++ sed -e 's/"\?--with-linux=[^ ][^ ]* \?//'
+ CONFIGURE_ARGS=''\''--with-o2ib=/usr/src/ofa_kernel/default'\'''
++ echo ''\''--with-o2ib=/usr/src/ofa_kernel/default'\'''
++ sed -e 's/"\?--with-linux-obj=[^ ][^ ]* \?//'
+ CONFIGURE_ARGS=''\''--with-o2ib=/usr/src/ofa_kernel/default'\'''
++ echo ''\''--with-o2ib=/usr/src/ofa_kernel/default'\'''
++ sed -e 's/"\?--with-kmp-moddir=[^ ][^ ]* \?//'
+ CONFIGURE_ARGS=''\''--with-o2ib=/usr/src/ofa_kernel/default'\'''
+ '[' -f '' ']'
+ WITH_O2IB=
++ xargs dirname
+++ echo --with-o2ib=/usr/src/ofa_kernel/default
+++ tr ' ' '\n'
+++ grep -- --with-o2ib=
+++ cut -c 13-
++ find /usr/src/ofa_kernel/default -type d -name ofed_scripts
dirname: missing operand
Try 'dirname --help' for more information.
+ o2ib_path=
error: Bad exit status from /tmp/rpmbuild-lustre-root-5bVhWL5I/TMP/rpm-tmp.dGQGBH (%build)


RPM build errors:
    Bad exit status from /tmp/rpmbuild-lustre-root-5bVhWL5I/TMP/rpm-tmp.dGQGBH (%build)
make: *** [autoMakefile:1318: rpms] Error 1

one before patch landed (e.g. commit "fdab3f6455 LU-17398 build: quash rpmbuild false warning") worked fine

Issue Links

• is related to: LU-17398 Quash rpmbuild false warning due to %() in comment
• is related to: LU-17507 MOFED find should use -H in cases where /usr/src/ofa_kernel/default is a symlink

Comments

[Peter Jones]

As per discussion on the LWG call today, moving tickets that do not appear to be essential to fix version 2.17. If the fix lands before code freeze we will update the fix version to reflect that but we want to focus on activities on the critical path. Please speak up if you think that this issue definitely needs to be fixed before we could issue a 2.16 release.

[Shuichi Ihara]

thx! patch worked and solved problem.

[Shaun Tancheff]

@Shuichi Ihara
Please see if this fix works for you:
https://review.whamcloud.com/c/fs/lustre-release/+/53934