Details
-
Improvement
-
Resolution: Unresolved
-
Minor
-
None
-
None
-
None
-
3
-
9223372036854775807
Description
It's appears that `ptlrpc_connection` tracking and handling can be simplified significantly. I have some draft patches demonstrating this. Based on my testing (and this patch series), I'm convinced that `ptlrpc_connection` is a superfluous wrapper around `lnet_processid`. This rhashtable just maps a `lnet_processid` to a `ptlrpc_connection` containing the very same `lnet_processid`. The other fields in `ptlrpc_connection` either for object lifetime management or can be trivially derived from LNet.
From my understanding so far, I think we could eventually remove `ptlrpc_connection` by relying more on LNet as a source of truth.
My main motivation for this work: this hash table seems to retain incorrect information from past "connections" in many cases (for example, if you often re-use NIDs from old clients).