[LU-17621] Coverity: 415060 (Logically dead code) under o2iblnd.c

• Type: Bug
• Resolution: Fixed
• Priority: Minor
• Fix Version/s: Lustre 2.16.0
• Severity: 3
• Assignee: James A Simmons
• Reporter: Arshad Hussain

Description

This was reported by https://scan4.scan.coverity.com/#/project-view/10072/17272?selectedIssue=415060 and it does look legit.

Patch causing this : LU-10391 lnet: support updating LNet local NI settings (git show 9b05e872482)

Comparision will always be true. If it is the range which is required then it should be logical &&. ?

num = nla_get_s64(attr);                                        
if (num > -1 || num < 128) ## <--- This will always be true.                                       
    tunables->lnd_tun_u.lnd_o2ib.lnd_conns_per_peer = num;  
else                                                            
    rc = -ERANGE;