[LU-17734] Debian: include tests by default, but oblige --disable-tests if asked

• Type: Bug
• Resolution: Fixed
• Priority: Minor
• Fix Version/s: Lustre 2.16.0
• Labels: msft
• Severity: 3
• Assignee: Ellis Wilson
• Reporter: Ellis Wilson

Description

The original bug that turned up issues relating to the lack of inclusion of testing kernel modules (llog_test.ko and kinode.ko) against 2.15.4 is still listed below, but these inclusions were found to be already achieved in the following patches against master:
https://review.whamcloud.com/c/fs/lustre-release/+/52597
https://review.whamcloud.com/c/fs/lustre-release/+/52398

This bug now just tracks including the tests by default, but allowing for the end user to disable them via "--disable-tests" if they so choose.

Original bug description:

2021-09-20 19:29:23,050 INF == sanity test 60a: llog_test run from kernel module and test llog_reader ============================ 19:29:23 (1632166163)
2021-09-20 19:29:23,661 INF pdsh@da8599b6-f1c3-4147-bb91-5050bd2196f4-MDS-0-0: node01: ssh exited with exit code 1
2021-09-20 19:29:23,662 INF test_60 run 11105 - from kernel mode
2021-09-20 19:29:25,226 INF node01: ++ /usr/sbin/lctl dl
2021-09-20 19:29:25,226 INF node01: ++ awk '/mgs/ { print $4 }'
2021-09-20 19:29:25,231 INF node01: + MGS=MGS
2021-09-20 19:29:25,232 INF node01: + '[' -z MGS ']'
2021-09-20 19:29:25,232 INF node01: + load_module obdclass/llog_test
2021-09-20 19:29:25,232 INF node01: + local module=obdclass/llog_test
2021-09-20 19:29:25,232 INF node01: + shift
2021-09-20 19:29:25,232 INF node01: + local ext=.ko
2021-09-20 19:29:25,232 INF node01: ++ basename obdclass/llog_test .ko
2021-09-20 19:29:25,234 INF node01: + local base=llog_test
2021-09-20 19:29:25,234 INF node01: + local path
2021-09-20 19:29:25,234 INF node01: + local -A module_is_loaded_aa
2021-09-20 19:29:25,234 INF node01: + local optvar
2021-09-20 19:29:25,234 INF node01: + local mod
2021-09-20 19:29:25,235 INF node01: ++ lsmod
2021-09-20 19:29:25,235 INF node01: ++ awk '{ print $1; }'
2021-09-20 19:29:25,240 INF node01: + for mod in $(lsmod | awk '{ print $1; }')
2021-09-20 19:29:25,241 INF node01: + module_is_loaded_aa[${mod//-/_}]=true
2021-09-20 19:29:25,241 INF node01: + for mod in $(lsmod | awk '{ print $1; }')
...

2021-09-20 19:29:25,251 INF node01: + optvar=MODOPTS_LLOG_TEST
2021-09-20 19:29:25,251 INF node01: + eval set – '$MODOPTS_LLOG_TEST'
2021-09-20 19:29:25,251 INF node01: ++ set –
2021-09-20 19:29:25,251 INF node01: + '[' 0 -eq 0 -a -n '' ']'
2021-09-20 19:29:25,251 INF node01: + '[' 0 -gt 0 ']'
2021-09-20 19:29:25,251 INF node01: + [[ -n '' ]]
2021-09-20 19:29:25,251 INF node01: + [[ llog_test == ptlrpc_gss ]]
2021-09-20 19:29:25,251 INF node01: + modprobe llog_test
2021-09-20 19:29:25,251 INF node01: modprobe: FATAL: Module llog_test not found in directory /lib/modules/5.4.106-laaso
2021-09-20 19:29:25,251 INF node01: + exit 1
2021-09-20 19:29:25,251 INF pdsh@da8599b6-f1c3-4147-bb91-5050bd2196f4-MDS-0-0: node01: ssh exited with exit code 1
2021-09-20 19:29:25,251 INF  sanity test_60a: @@@@@@ FAIL: run-llog.sh failed
2021-09-20 19:29:25,612 INF   Trace dump:
2021-09-20 19:29:25,613 INF   = /usr/lib/lustre/tests/test-framework.sh:6273:error()
2021-09-20 19:29:25,613 INF   = /usr/lib/lustre/tests/sanity.sh:7606:test_60a()
2021-09-20 19:29:25,613 INF   = /usr/lib/lustre/tests/test-framework.sh:6581:run_one()
2021-09-20 19:29:25,613 INF   = /usr/lib/lustre/tests/test-framework.sh:6628:run_one_logged()
2021-09-20 19:29:25,613 INF   = /usr/lib/lustre/tests/test-framework.sh:6455:run_test()
2021-09-20 19:29:25,613 INF   = /usr/lib/lustre/tests/sanity.sh:7683:main()
2021-09-20 19:29:25,685 INF Dumping lctl log to /opt/results/1632164066.721736/2021-09-20/185715/sanity.test_60a.*.1632166165.log
2021-09-20 19:29:26,945 INF Resetting fail_loc on all nodes...done.
2021-09-20 19:29:26,952 INF FAIL 60a (3s)

This hits on debian-based systems due to lustre-server-modules not including kernel modules required for testing (e.g., llog_test.ko and kinode.ko).  Lack of these causes test_60a to fail.

Patch to be sent shortly.