Uploaded image for project: 'Lustre'
  1. Lustre
  2. LU-1779

"skip" inside a test does not report SKIP in Maloo

Details

    • 1
    • 3
    • 2206

    Description

      It seems that tests in ALWAYS_EXCEPT are reported in maloo as "skip ALWAYS excluded test NN". However, if some test is skipped due to an environmental condition (e.g. sanity.sh test_27m, which is testing out-of-space conditions and is skipped during review runs when the filesystem is too large, as in https://maloo.whamcloud.com/sub_tests/78d60ce0-9dc0-11e1-a1d8-52540035b04c) this will print a "SKIP" message in the test, but the test itself is reported as "PASS" Maloo.

      It would be more useful if the test were reported in Maloo as "SKIP: sanity test_27m 892015396 > 1400000 skipping out-of-space test on OST0". What does auster/Maloo key on to determine whether a test is SKIP or PASS, and what needs to be done to make the "skip" directive inside a test cause Maloo to report the test as skipped?

      The reason this is of interest is because I want the tests skipped because of LU-482 to be clearly flagged as not having been run, rather than pretending the test has passed. The patch in http://review.whamcloud.com/2731 will mark the test with "skip", but until this issue is fixed then the whole replay-dual will appear to be a PASS, even though nothing was run.

      Attachments

        Issue Links

          is related to

          Bug - A problem which impairs or prevents the functions of the product. LU-482 Test failure on test suite replay-dual, subtest test_0a

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Resolved
          Trackbacks

          [Confluence: Operations] JIRA and Confluence Upgrade Plan Problem statement Currently our bug tracking system (JIRA) and wiki (Confluence) are running versions that are frighteningly outofdate, to the point that for our upgrade of Confluence,...

          Activity

            [LU-1779] "skip" inside a test does not report SKIP in Maloo
            yujian Jian Yu added a comment -

            Patch for b1_8 branch: http://review.whamcloud.com/4955

            yujian Jian Yu added a comment - Patch for b1_8 branch: http://review.whamcloud.com/4955
            adilger Andreas Dilger added a comment -

            Patch landed on b2_1, b2_3, master.

            adilger Andreas Dilger added a comment - Patch landed on b2_1, b2_3, master.
            yujian Jian Yu added a comment -

            Patch for b2_1 branch: http://review.whamcloud.com/3899

            The one for master and b2_3 branches has been landed.

            yujian Jian Yu added a comment - Patch for b2_1 branch: http://review.whamcloud.com/3899 The one for master and b2_3 branches has been landed.
            yujian Jian Yu added a comment -

            Patch for master branch: http://review.whamcloud.com/3810

            yujian Jian Yu added a comment - Patch for master branch: http://review.whamcloud.com/3810
            chris Chris Gearing (Inactive) added a comment -

            The problem here is that the test framework is reporting PASS in the yaml. We need to make the test framework behave properly.

            chris Chris Gearing (Inactive) added a comment - The problem here is that the test framework is reporting PASS in the yaml. We need to make the test framework behave properly.

            People

              yujian Jian Yu
              adilger Andreas Dilger
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: