Uploaded image for project: 'Lustre'
  1. Lustre
  2. LU-17799

CoverityId 425359: Calling "cl_page_own" without checking return value

    XMLWordPrintable

Details

    • Bug
    • Resolution: Unresolved
    • Minor
    • None
    • None
    • 3
    • 9223372036854775807

    Description

      git blame points to patch: b651089f

      > *** CID 425359:  Error handling issues  (CHECKED_RETURN)
      > /lustre/llite/vvp_io.c: 1645 in vvp_io_fault_start()
      > 1639                 if (result == -EDQUOT) {
      > 1640                     cl_page_get(page);
      > 1641                     result = vvp_io_commit_sync(env, io,
      > 1642                                     plist, 0, to);
      > 1643                     if (result >= 0) {
      > 1644                         io->ci_noquota = 1;
      >>>>    CID 425359:  Error handling issues  (CHECKED_RETURN)
      >>>>    Calling "cl_page_own" without checking return value (as is done elsewhere 5 out of 6 times).
      > 1645                         cl_page_own(env, io, page);
      > 1646                         cl_page_list_add(plist, page, true);
      > 1647                         lu_ref_add(&page->cp_reference,
      > 1648                                "cl_io", io);
      > 1649                         result = cl_io_commit_async(env, io,
      > 1650                             plist, 0, to,

      Attachments

        Activity

          People

            wc-triage WC Triage
            arshad512 Arshad Hussain
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated: