Uploaded image for project: 'Lustre'
  1. Lustre
  2. LU-17918

protect layout in ll_delete_inode

Details

    • Bug
    • Resolution: Unresolved
    • Major
    • None
    • None
    • None
    • 3
    • 9223372036854775807

    Description

      When an inode is evicted during unmounting, it would write out dirty pages, we need to protect the layout since it could be changed by mirror operations at the same time.

      BUG: unable to handle kernel NULL pointer dereference at 0000000000006
IP: cl_object_top+0xe/0x130 [obdclass]
Call Trace:
    cl_io_sub_init+0x1f/0x70 [obdclass]
    lov_sub_get+0x52a/0x910 [lov]
    lov_io_iter_init+0x2da/0xab0 [lov]
    cl_io_iter_init+0x51/0x100 [obdclass]
    cl_io_loop+0x71/0x200 [obdclass]
    cl_sync_file_range+0x142/0x150 [lustre]
    cl_delete_inode+0x142/0x150 [lustre]
    evict+0xd2/0x1a0

      Attachments

        Issue Links

          is related to

          Improvement - An improvement or enhancement to an existing feature or task. LU-17970 Add lock match flag LDLM_MATCH_SKIP_UNUSED

          • Major - Major loss of function.
          • Resolved

          Activity

            [LU-17918] protect layout in ll_delete_inode
            bobijam Zhenyu Xu added a comment -

            This could be an incorrect analysis, only MISC IO with ignore layout (io->ci_ignore_layout && io->ci_type == CIT_MISC) would call LOV dispatch functions without lov->lo_type_guard lock, and FSYNC IO will always take LOV type guard lock.

            This issue is that it is trying to access an invalid sub-objects (lov_layout_raid0::lo_sub)

            bobijam Zhenyu Xu added a comment - This could be an incorrect analysis, only MISC IO with ignore layout (io->ci_ignore_layout && io->ci_type == CIT_MISC) would call LOV dispatch functions without lov->lo_type_guard lock, and FSYNC IO will always take LOV type guard lock. This issue is that it is trying to access an invalid sub-objects (lov_layout_raid0::lo_sub)
            gerrit Gerrit Updater added a comment -

            "Zhenyu Xu <bobijam@hotmail.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/55361
            Subject: LU-17918 llite: protect layout in ll_delete_inode
            Project: fs/lustre-release
            Branch: master
            Current Patch Set: 1
            Commit: a2bba4892c64cd915c2e333ec88ab0a713cd9d0a

            gerrit Gerrit Updater added a comment - "Zhenyu Xu <bobijam@hotmail.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/55361 Subject: LU-17918 llite: protect layout in ll_delete_inode Project: fs/lustre-release Branch: master Current Patch Set: 1 Commit: a2bba4892c64cd915c2e333ec88ab0a713cd9d0a

            People

              bobijam Zhenyu Xu
              bobijam Zhenyu Xu
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

                Created:
                Updated: