Details

    • Improvement
    • Resolution: Fixed
    • Minor
    • Lustre 2.16.0
    • None
    • None
    • 3
    • 9223372036854775807

    Description

      Request allocation code in PTLRPC returns NULL on error and callers assume this is due to the system being out of memory.

      Actually, there are multiple reasons this could fail like GSS error or failure to reconnect from an IDLE state. So let's improve that, making ptlrpc_request_alloc_pack() returns the actual error that will be bumped to the caller and likely the user-space, making debugging easier instead of always falsely return "System is out of memory" which is wrong most of the time.

      Attachments

        Activity

          [LU-17929] Improve ptlrpc error reporting
          pjones Peter Jones added a comment -

          Merged for 2.16

          pjones Peter Jones added a comment - Merged for 2.16

          "Oleg Drokin <green@whamcloud.com>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/55391/
          Subject: LU-17929 ptlrpc: ptlrpc_request_alloc_pack() always returns an error code
          Project: fs/lustre-release
          Branch: master
          Current Patch Set:
          Commit: fc00b7e3d1bbb6ad390c5d69a73353cb7b61960a

          gerrit Gerrit Updater added a comment - "Oleg Drokin <green@whamcloud.com>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/55391/ Subject: LU-17929 ptlrpc: ptlrpc_request_alloc_pack() always returns an error code Project: fs/lustre-release Branch: master Current Patch Set: Commit: fc00b7e3d1bbb6ad390c5d69a73353cb7b61960a

          "Aurelien Degremont <adegremont@nvidia.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/55391
          Subject: LU-17929 ptlrpc: ptlrpc_request_alloc_pack() always returns an error code
          Project: fs/lustre-release
          Branch: master
          Current Patch Set: 1
          Commit: f9d41fa02b18518ca1b5a5761bae037a6fea9370

          gerrit Gerrit Updater added a comment - "Aurelien Degremont <adegremont@nvidia.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/55391 Subject: LU-17929 ptlrpc: ptlrpc_request_alloc_pack() always returns an error code Project: fs/lustre-release Branch: master Current Patch Set: 1 Commit: f9d41fa02b18518ca1b5a5761bae037a6fea9370

          People

            adegremont_nvda Aurelien Degremont
            adegremont_nvda Aurelien Degremont
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: