[LU-18009] Remove o_fid_init/o_fid_fini - Whamcloud Community JIRA

Details

Type: Task
Resolution: Fixed
Priority: Minor
Fix Version/s: Lustre 2.16.0, Lustre 2.17.0
Affects Version/s: None
Labels:
- janitor9x

Severity:
3
Rank (Obsolete):
9223372036854775807

Description

In every case, o_fid_init is client_fid_init and o_fid_fini is client_fid_fini. Remove these function pointers.

Attachments

Issue Links

is related to

LU-18683 uninitialized semaphore in client_fid_init()

Resolved

LU-18037 Remove o_add_conn/o_del_conn

Open

is related to

LU-16807 Resolve newer debug kernel warnings

Reopened

Activity

[LU-18009] Remove o_fid_init/o_fid_fini

James A Simmons added a comment - 14/Feb/25 3:10 AM

https://review.whamcloud.com/#/c/fs/lustre-release/+/57918 resolved the bug

James A Simmons added a comment - 14/Feb/25 3:10 AM https://review.whamcloud.com/#/c/fs/lustre-release/+/57918 resolved the bug

Tim Day added a comment - 18/Jan/25 8:37 PM

I'll take a look at this. If I can't work something out, I'll submit a revert.

Tim Day added a comment - 18/Jan/25 8:37 PM I'll take a look at this. If I can't work something out, I'll submit a revert.

Oleg Drokin added a comment - 18/Jan/25 6:44 PM

I know this was landed awhile ago, but as I am preparing to switch to rhel8/9 in janitor I was scouring the logs and found that this actually seems to break sosme semaphore initialization resulting in this warning at mount time on a client:

 [  144.685688] Lustre: lustre-OST0000-osc-MDT0000: update sequence from 0x100000000 to 0x240000400
[  145.907787] ------------[ cut here ]------------
[  145.909248] DEBUG_RWSEMS_WARN_ON(sem->magic != sem): count = 0x0, magic = 0x0, owner = 0x0, curr 0xffff888014fb9700, list not empty
[  145.912166] WARNING: CPU: 1 PID: 4582 at kernel/locking/rwsem.c:1288 down_write+0x209/0x240
[  145.913998] Modules linked in: loop zfs(O) zunicode(O) zzstd(O) zlua(O) zcommon(O) znvpair(O) zavl(O) icp(O) spl(O) lustre(O) osp(O) ofd(O) lod(O) ost(O) mdt(O) mdd(O) mgs(O) osd_ldiskfs(O) ldiskfs(O) lquota(O) lfsck(O) obdecho(O) mgc(O) mdc(O) lov(O) osc(O) lmv(O) fid(O) fld(O) ptlrpc_gss(O) ptlrpc(O) obdclass(O) ksocklnd(O) lnet(O) libcfs(O) dm_flakey rpcsec_gss_krb5 auth_rpcgss nfsv4 dns_resolver intel_rapl_msr intel_rapl_common rapl pcspkr i2c_piix4 squashfs crct10dif_pclmul crc32_pclmul crc32c_intel ata_generic ghash_clmulni_intel serio_raw ata_piix libata dm_mirror dm_region_hash dm_log dm_mod sha512_ssse3 sha512_generic
[  145.924148] CPU: 1 PID: 4582 Comm: mount.lustre Kdump: loaded Tainted: G        W  O     --------- -  - 4.18.0rh8.5-debug #2
[  145.925917] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.16.3-1.fc39 04/01/2014
[  145.927321] RIP: 0010:down_write+0x209/0x240
[  145.928031] Code: 8b 43 68 48 c7 c6 43 35 b4 82 48 c7 c7 80 35 b4 82 48 8b 13 65 4c 8b 0c 25 80 5e 01 00 e8 95 67 03 ff 48 83 05 2f c6 04 02 01 <0f> 0b 48 83 05 2d c6 04 02 01 48 83 05 2d c6 04 02 01 58 eb 82 48
[  145.930847] RSP: 0018:ffffc9000731fba0 EFLAGS: 00010202
[  145.931583] RAX: 0000000000000000 RBX: ffff888014403a68 RCX: 0000000000000000
[  145.932622] RDX: ffff8881417f7660 RSI: ffff8881417e69e8 RDI: ffff8881417e69e8
[  145.933725] RBP: ffffc9000731fcb0 R08: 0000000000000000 R09: 0000000000000000
[  145.934745] R10: 0000000000000086 R11: ffffc9000731fa00 R12: ffff888014403a68
[  145.935768] R13: ffff888014403ae0 R14: 0000000000000001 R15: ae7e5e7be374d3b8
[  145.936731] FS:  00007f7ba988b8c0(0000) GS:ffff888141600000(0000) knlGS:0000000000000000
[  145.937816] CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[  145.938590] CR2: 0000556179979028 CR3: 0000000014e88001 CR4: 0000000000170ee0
[  145.939537] Call Trace:
[  145.939872]  client_fid_init+0x4b/0x630 [fid]
[  145.940475]  client_common_fill_super+0xade/0x3c60 [lustre]
[  145.941199]  ? snprintf+0x51/0x70
[  145.941642]  ll_fill_super+0x10cc/0x1530 [lustre]
[  145.942294]  ? obd_zombie_barrier+0x63/0x120 [obdclass]
[  145.942943]  ? debug_mutex_init+0x43/0x60
[  145.943461]  lustre_fill_super+0x15a/0x5e0 [lustre]
[  145.944096]  ? lustre_mount+0x30/0x30 [lustre]
[  145.944592]  mount_nodev+0x58/0x100
[  145.945017]  lustre_mount+0x1c/0x30 [lustre]
[  145.945496]  legacy_get_tree+0x38/0x90
[  145.945914]  vfs_get_tree+0x30/0x140
[  145.946333]  do_mount+0xcad/0x10b0
[  145.946709]  ksys_mount+0x11d/0x150
[  145.947113]  __x64_sys_mount+0x29/0x40
[  145.947522]  do_syscall_64+0xd4/0x5a0
[  145.947916]  entry_SYSCALL_64_after_hwframe+0x6a/0xdf
[  145.948476] RIP: 0033:0x7f7ba609992e
[  145.948872] Code: 48 8b 0d 5d 15 2c 00 f7 d8 64 89 01 48 83 c8 ff c3 66 2e 0f 1f 84 00 00 00 00 00 90 f3 0f 1e fa 49 89 ca b8 a5 00 00 00 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 8b 0d 2a 15 2c 00 f7 d8 64 89 01 48
[  145.950909] RSP: 002b:00007fff3201c618 EFLAGS: 00000206 ORIG_RAX: 00000000000000a5
[  145.951736] RAX: ffffffffffffffda RBX: 00007fff32022ca8 RCX: 00007f7ba609992e
[  145.952498] RDX: 0000000000412d3e RSI: 00007fff32022ca8 RDI: 00000000022c5510
[  145.953244] RBP: 0000000000000000 R08: 00000000022c7210 R09: 0000000000000000
[  145.954002] R10: 0000000001000000 R11: 0000000000000206 R12: 0000000000412d3e
[  145.954729] R13: 00007fff32025953 R14: 00000000fffffff5 R15: 00000000fffffff5
[  145.955458] irq event stamp: 0
[  145.955776] hardirqs last  enabled at (0): [<0000000000000000>] 0x0
[  145.956399] hardirqs last disabled at (0): [<ffffffff8111fd5a>] copy_process+0xe6a/0x2840
[  145.957165] softirqs last  enabled at (0): [<ffffffff8111fd5a>] copy_process+0xe6a/0x2840
[  145.957968] softirqs last disabled at (0): [<0000000000000000>] 0x0
[  145.958583] ---[ end trace 145a0ead300d9c64 ]---
[  145.959129] ------------[ cut here ]------------
[  145.959590] DEBUG_RWSEMS_WARN_ON(sem->magic != sem): count = 0x1, magic = 0x0, owner = 0xffff888014fb9700, curr 0xffff888014fb9700, list not empty
[  145.960830] WARNING: CPU: 1 PID: 4582 at kernel/locking/rwsem.c:1319 up_write+0x18b/0x240
[  145.961583] Modules linked in: loop zfs(O) zunicode(O) zzstd(O) zlua(O) zcommon(O) znvpair(O) zavl(O) icp(O) spl(O) lustre(O) osp(O) ofd(O) lod(O) ost(O) mdt(O) mdd(O) mgs(O) osd_ldiskfs(O) ldiskfs(O) lquota(O) lfsck(O) obdecho(O) mgc(O) mdc(O) lov(O) osc(O) lmv(O) fid(O) fld(O) ptlrpc_gss(O) ptlrpc(O) obdclass(O) ksocklnd(O) lnet(O) libcfs(O) dm_flakey rpcsec_gss_krb5 auth_rpcgss nfsv4 dns_resolver intel_rapl_msr intel_rapl_common rapl pcspkr i2c_piix4 squashfs crct10dif_pclmul crc32_pclmul crc32c_intel ata_generic ghash_clmulni_intel serio_raw ata_piix libata dm_mirror dm_region_hash dm_log dm_mod sha512_ssse3 sha512_generic
[  145.966457] CPU: 1 PID: 4582 Comm: mount.lustre Kdump: loaded Tainted: G        W  O     --------- -  - 4.18.0rh8.5-debug #2
[  145.967457] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.16.3-1.fc39 04/01/2014
[  145.968233] RIP: 0010:up_write+0x18b/0x240
[  145.968583] Code: 8b 43 68 48 c7 c6 43 35 b4 82 48 c7 c7 80 35 b4 82 48 8b 13 65 4c 8b 0c 25 80 5e 01 00 e8 33 2a f5 ff 48 83 05 4d 8a f6 02 01 <0f> 0b 48 83 05 4b 8a f6 02 01 48 83 05 4b 8a f6 02 01 59 e9 4c ff
[  145.970151] RSP: 0018:ffffc9000731fbb8 EFLAGS: 00010202
[  145.970587] RAX: 0000000000000000 RBX: ffff888014403a68 RCX: 0000000000000000
[  145.971190] RDX: ffff8881417f7660 RSI: ffff8881417e69e8 RDI: ffff8881417e69e8
[  145.971764] RBP: ffff888109ba1180 R08: 0000000000000000 R09: 0000000000000000
[  145.972344] R10: 0000000000000095 R11: ffffc9000731fa18 R12: ffff888014403a68
[  145.972911] R13: ffff88800d1d5000 R14: 0000000000000001 R15: ae7e5e7be374d3b8
[  145.973499] FS:  00007f7ba988b8c0(0000) GS:ffff888141600000(0000) knlGS:0000000000000000
[  145.974170] CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[  145.974610] CR2: 0000556179979028 CR3: 0000000014e88001 CR4: 0000000000170ee0
[  145.975161] Call Trace:
[  145.975362]  client_fid_init+0x1c0/0x630 [fid]
[  145.975718]  client_common_fill_super+0xade/0x3c60 [lustre]
[  145.976189]  ? snprintf+0x51/0x70
[  145.976488]  ll_fill_super+0x10cc/0x1530 [lustre]
[  145.976878]  ? obd_zombie_barrier+0x63/0x120 [obdclass]
[  145.977301]  ? debug_mutex_init+0x43/0x60
[  145.977632]  lustre_fill_super+0x15a/0x5e0 [lustre]
[  145.978054]  ? lustre_mount+0x30/0x30 [lustre]
[  145.978394]  mount_nodev+0x58/0x100
[  145.978681]  lustre_mount+0x1c/0x30 [lustre]
[  145.979050]  legacy_get_tree+0x38/0x90
[  145.979338]  vfs_get_tree+0x30/0x140
[  145.979612]  do_mount+0xcad/0x10b0
[  145.979867]  ksys_mount+0x11d/0x150
[  145.980172]  __x64_sys_mount+0x29/0x40
[  145.980457]  do_syscall_64+0xd4/0x5a0
[  145.980739]  entry_SYSCALL_64_after_hwframe+0x6a/0xdf
[  145.981160] RIP: 0033:0x7f7ba609992e
[  145.981443] Code: 48 8b 0d 5d 15 2c 00 f7 d8 64 89 01 48 83 c8 ff c3 66 2e 0f 1f 84 00 00 00 00 00 90 f3 0f 1e fa 49 89 ca b8 a5 00 00 00 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 8b 0d 2a 15 2c 00 f7 d8 64 89 01 48
[  145.982839] RSP: 002b:00007fff3201c618 EFLAGS: 00000206 ORIG_RAX: 00000000000000a5
[  145.983436] RAX: ffffffffffffffda RBX: 00007fff32022ca8 RCX: 00007f7ba609992e
[  145.983974] RDX: 0000000000412d3e RSI: 00007fff32022ca8 RDI: 00000000022c5510
[  145.984525] RBP: 0000000000000000 R08: 00000000022c7210 R09: 0000000000000000
[  145.985091] R10: 0000000001000000 R11: 0000000000000206 R12: 0000000000412d3e
[  145.985610] R13: 00007fff32025953 R14: 00000000fffffff5 R15: 00000000fffffff5
[  145.986198] irq event stamp: 0
[  145.986433] hardirqs last  enabled at (0): [<0000000000000000>] 0x0
[  145.986877] hardirqs last disabled at (0): [<ffffffff8111fd5a>] copy_process+0xe6a/0x2840
[  145.987520] softirqs last  enabled at (0): [<ffffffff8111fd5a>] copy_process+0xe6a/0x2840
[  145.988161] softirqs last disabled at (0): [<0000000000000000>] 0x0
[  145.988619] ---[ end trace 145a0ead300d9c65 ]---
[  145.998821] Lustre: Mounted lustre-client

I specifically tried to build with this githash 424b9ccb004644877ee59d4cd6b2e578ae3b21bd and the warning is there and then the commit preceeding it: 0359455f8a98f960f7b822e8f5468d94f437d93b and the warning is not present.

So we need to do something about it.

Oleg Drokin added a comment - 18/Jan/25 6:44 PM I know this was landed awhile ago, but as I am preparing to switch to rhel8/9 in janitor I was scouring the logs and found that this actually seems to break sosme semaphore initialization resulting in this warning at mount time on a client: [ 144.685688] Lustre: lustre-OST0000-osc-MDT0000: update sequence from 0x100000000 to 0x240000400 [ 145.907787] ------------[ cut here ]------------ [ 145.909248] DEBUG_RWSEMS_WARN_ON(sem->magic != sem): count = 0x0, magic = 0x0, owner = 0x0, curr 0xffff888014fb9700, list not empty [ 145.912166] WARNING: CPU: 1 PID: 4582 at kernel/locking/rwsem.c:1288 down_write+0x209/0x240 [ 145.913998] Modules linked in: loop zfs(O) zunicode(O) zzstd(O) zlua(O) zcommon(O) znvpair(O) zavl(O) icp(O) spl(O) lustre(O) osp(O) ofd(O) lod(O) ost(O) mdt(O) mdd(O) mgs(O) osd_ldiskfs(O) ldiskfs(O) lquota(O) lfsck(O) obdecho(O) mgc(O) mdc(O) lov(O) osc(O) lmv(O) fid(O) fld(O) ptlrpc_gss(O) ptlrpc(O) obdclass(O) ksocklnd(O) lnet(O) libcfs(O) dm_flakey rpcsec_gss_krb5 auth_rpcgss nfsv4 dns_resolver intel_rapl_msr intel_rapl_common rapl pcspkr i2c_piix4 squashfs crct10dif_pclmul crc32_pclmul crc32c_intel ata_generic ghash_clmulni_intel serio_raw ata_piix libata dm_mirror dm_region_hash dm_log dm_mod sha512_ssse3 sha512_generic [ 145.924148] CPU: 1 PID: 4582 Comm: mount.lustre Kdump: loaded Tainted: G W O --------- - - 4.18.0rh8.5-debug #2 [ 145.925917] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.16.3-1.fc39 04/01/2014 [ 145.927321] RIP: 0010:down_write+0x209/0x240 [ 145.928031] Code: 8b 43 68 48 c7 c6 43 35 b4 82 48 c7 c7 80 35 b4 82 48 8b 13 65 4c 8b 0c 25 80 5e 01 00 e8 95 67 03 ff 48 83 05 2f c6 04 02 01 <0f> 0b 48 83 05 2d c6 04 02 01 48 83 05 2d c6 04 02 01 58 eb 82 48 [ 145.930847] RSP: 0018:ffffc9000731fba0 EFLAGS: 00010202 [ 145.931583] RAX: 0000000000000000 RBX: ffff888014403a68 RCX: 0000000000000000 [ 145.932622] RDX: ffff8881417f7660 RSI: ffff8881417e69e8 RDI: ffff8881417e69e8 [ 145.933725] RBP: ffffc9000731fcb0 R08: 0000000000000000 R09: 0000000000000000 [ 145.934745] R10: 0000000000000086 R11: ffffc9000731fa00 R12: ffff888014403a68 [ 145.935768] R13: ffff888014403ae0 R14: 0000000000000001 R15: ae7e5e7be374d3b8 [ 145.936731] FS: 00007f7ba988b8c0(0000) GS:ffff888141600000(0000) knlGS:0000000000000000 [ 145.937816] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [ 145.938590] CR2: 0000556179979028 CR3: 0000000014e88001 CR4: 0000000000170ee0 [ 145.939537] Call Trace: [ 145.939872] client_fid_init+0x4b/0x630 [fid] [ 145.940475] client_common_fill_super+0xade/0x3c60 [lustre] [ 145.941199] ? snprintf+0x51/0x70 [ 145.941642] ll_fill_super+0x10cc/0x1530 [lustre] [ 145.942294] ? obd_zombie_barrier+0x63/0x120 [obdclass] [ 145.942943] ? debug_mutex_init+0x43/0x60 [ 145.943461] lustre_fill_super+0x15a/0x5e0 [lustre] [ 145.944096] ? lustre_mount+0x30/0x30 [lustre] [ 145.944592] mount_nodev+0x58/0x100 [ 145.945017] lustre_mount+0x1c/0x30 [lustre] [ 145.945496] legacy_get_tree+0x38/0x90 [ 145.945914] vfs_get_tree+0x30/0x140 [ 145.946333] do_mount+0xcad/0x10b0 [ 145.946709] ksys_mount+0x11d/0x150 [ 145.947113] __x64_sys_mount+0x29/0x40 [ 145.947522] do_syscall_64+0xd4/0x5a0 [ 145.947916] entry_SYSCALL_64_after_hwframe+0x6a/0xdf [ 145.948476] RIP: 0033:0x7f7ba609992e [ 145.948872] Code: 48 8b 0d 5d 15 2c 00 f7 d8 64 89 01 48 83 c8 ff c3 66 2e 0f 1f 84 00 00 00 00 00 90 f3 0f 1e fa 49 89 ca b8 a5 00 00 00 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 8b 0d 2a 15 2c 00 f7 d8 64 89 01 48 [ 145.950909] RSP: 002b:00007fff3201c618 EFLAGS: 00000206 ORIG_RAX: 00000000000000a5 [ 145.951736] RAX: ffffffffffffffda RBX: 00007fff32022ca8 RCX: 00007f7ba609992e [ 145.952498] RDX: 0000000000412d3e RSI: 00007fff32022ca8 RDI: 00000000022c5510 [ 145.953244] RBP: 0000000000000000 R08: 00000000022c7210 R09: 0000000000000000 [ 145.954002] R10: 0000000001000000 R11: 0000000000000206 R12: 0000000000412d3e [ 145.954729] R13: 00007fff32025953 R14: 00000000fffffff5 R15: 00000000fffffff5 [ 145.955458] irq event stamp: 0 [ 145.955776] hardirqs last enabled at (0): [<0000000000000000>] 0x0 [ 145.956399] hardirqs last disabled at (0): [<ffffffff8111fd5a>] copy_process+0xe6a/0x2840 [ 145.957165] softirqs last enabled at (0): [<ffffffff8111fd5a>] copy_process+0xe6a/0x2840 [ 145.957968] softirqs last disabled at (0): [<0000000000000000>] 0x0 [ 145.958583] ---[ end trace 145a0ead300d9c64 ]--- [ 145.959129] ------------[ cut here ]------------ [ 145.959590] DEBUG_RWSEMS_WARN_ON(sem->magic != sem): count = 0x1, magic = 0x0, owner = 0xffff888014fb9700, curr 0xffff888014fb9700, list not empty [ 145.960830] WARNING: CPU: 1 PID: 4582 at kernel/locking/rwsem.c:1319 up_write+0x18b/0x240 [ 145.961583] Modules linked in: loop zfs(O) zunicode(O) zzstd(O) zlua(O) zcommon(O) znvpair(O) zavl(O) icp(O) spl(O) lustre(O) osp(O) ofd(O) lod(O) ost(O) mdt(O) mdd(O) mgs(O) osd_ldiskfs(O) ldiskfs(O) lquota(O) lfsck(O) obdecho(O) mgc(O) mdc(O) lov(O) osc(O) lmv(O) fid(O) fld(O) ptlrpc_gss(O) ptlrpc(O) obdclass(O) ksocklnd(O) lnet(O) libcfs(O) dm_flakey rpcsec_gss_krb5 auth_rpcgss nfsv4 dns_resolver intel_rapl_msr intel_rapl_common rapl pcspkr i2c_piix4 squashfs crct10dif_pclmul crc32_pclmul crc32c_intel ata_generic ghash_clmulni_intel serio_raw ata_piix libata dm_mirror dm_region_hash dm_log dm_mod sha512_ssse3 sha512_generic [ 145.966457] CPU: 1 PID: 4582 Comm: mount.lustre Kdump: loaded Tainted: G W O --------- - - 4.18.0rh8.5-debug #2 [ 145.967457] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.16.3-1.fc39 04/01/2014 [ 145.968233] RIP: 0010:up_write+0x18b/0x240 [ 145.968583] Code: 8b 43 68 48 c7 c6 43 35 b4 82 48 c7 c7 80 35 b4 82 48 8b 13 65 4c 8b 0c 25 80 5e 01 00 e8 33 2a f5 ff 48 83 05 4d 8a f6 02 01 <0f> 0b 48 83 05 4b 8a f6 02 01 48 83 05 4b 8a f6 02 01 59 e9 4c ff [ 145.970151] RSP: 0018:ffffc9000731fbb8 EFLAGS: 00010202 [ 145.970587] RAX: 0000000000000000 RBX: ffff888014403a68 RCX: 0000000000000000 [ 145.971190] RDX: ffff8881417f7660 RSI: ffff8881417e69e8 RDI: ffff8881417e69e8 [ 145.971764] RBP: ffff888109ba1180 R08: 0000000000000000 R09: 0000000000000000 [ 145.972344] R10: 0000000000000095 R11: ffffc9000731fa18 R12: ffff888014403a68 [ 145.972911] R13: ffff88800d1d5000 R14: 0000000000000001 R15: ae7e5e7be374d3b8 [ 145.973499] FS: 00007f7ba988b8c0(0000) GS:ffff888141600000(0000) knlGS:0000000000000000 [ 145.974170] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [ 145.974610] CR2: 0000556179979028 CR3: 0000000014e88001 CR4: 0000000000170ee0 [ 145.975161] Call Trace: [ 145.975362] client_fid_init+0x1c0/0x630 [fid] [ 145.975718] client_common_fill_super+0xade/0x3c60 [lustre] [ 145.976189] ? snprintf+0x51/0x70 [ 145.976488] ll_fill_super+0x10cc/0x1530 [lustre] [ 145.976878] ? obd_zombie_barrier+0x63/0x120 [obdclass] [ 145.977301] ? debug_mutex_init+0x43/0x60 [ 145.977632] lustre_fill_super+0x15a/0x5e0 [lustre] [ 145.978054] ? lustre_mount+0x30/0x30 [lustre] [ 145.978394] mount_nodev+0x58/0x100 [ 145.978681] lustre_mount+0x1c/0x30 [lustre] [ 145.979050] legacy_get_tree+0x38/0x90 [ 145.979338] vfs_get_tree+0x30/0x140 [ 145.979612] do_mount+0xcad/0x10b0 [ 145.979867] ksys_mount+0x11d/0x150 [ 145.980172] __x64_sys_mount+0x29/0x40 [ 145.980457] do_syscall_64+0xd4/0x5a0 [ 145.980739] entry_SYSCALL_64_after_hwframe+0x6a/0xdf [ 145.981160] RIP: 0033:0x7f7ba609992e [ 145.981443] Code: 48 8b 0d 5d 15 2c 00 f7 d8 64 89 01 48 83 c8 ff c3 66 2e 0f 1f 84 00 00 00 00 00 90 f3 0f 1e fa 49 89 ca b8 a5 00 00 00 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 8b 0d 2a 15 2c 00 f7 d8 64 89 01 48 [ 145.982839] RSP: 002b:00007fff3201c618 EFLAGS: 00000206 ORIG_RAX: 00000000000000a5 [ 145.983436] RAX: ffffffffffffffda RBX: 00007fff32022ca8 RCX: 00007f7ba609992e [ 145.983974] RDX: 0000000000412d3e RSI: 00007fff32022ca8 RDI: 00000000022c5510 [ 145.984525] RBP: 0000000000000000 R08: 00000000022c7210 R09: 0000000000000000 [ 145.985091] R10: 0000000001000000 R11: 0000000000000206 R12: 0000000000412d3e [ 145.985610] R13: 00007fff32025953 R14: 00000000fffffff5 R15: 00000000fffffff5 [ 145.986198] irq event stamp: 0 [ 145.986433] hardirqs last enabled at (0): [<0000000000000000>] 0x0 [ 145.986877] hardirqs last disabled at (0): [<ffffffff8111fd5a>] copy_process+0xe6a/0x2840 [ 145.987520] softirqs last enabled at (0): [<ffffffff8111fd5a>] copy_process+0xe6a/0x2840 [ 145.988161] softirqs last disabled at (0): [<0000000000000000>] 0x0 [ 145.988619] ---[ end trace 145a0ead300d9c65 ]--- [ 145.998821] Lustre: Mounted lustre-client I specifically tried to build with this githash 424b9ccb004644877ee59d4cd6b2e578ae3b21bd and the warning is there and then the commit preceeding it: 0359455f8a98f960f7b822e8f5468d94f437d93b and the warning is not present. So we need to do something about it.

Peter Jones added a comment - 14/Jul/24 12:36 AM

Merged for 2.16

Peter Jones added a comment - 14/Jul/24 12:36 AM Merged for 2.16

Gerrit Updater added a comment - 13/Jul/24 8:58 PM

"Oleg Drokin <green@whamcloud.com>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/55667/
Subject: ~~LU-18009~~ obd: remove o_fid_init/o_fid_fini
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 424b9ccb004644877ee59d4cd6b2e578ae3b21bd

Gerrit Updater added a comment - 13/Jul/24 8:58 PM "Oleg Drokin <green@whamcloud.com>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/55667/ Subject: LU-18009 obd: remove o_fid_init/o_fid_fini Project: fs/lustre-release Branch: master Current Patch Set: Commit: 424b9ccb004644877ee59d4cd6b2e578ae3b21bd

Gerrit Updater added a comment - 08/Jul/24 9:24 PM

"Timothy Day <timday@amazon.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/55667
Subject: ~~LU-18009~~ obd: remove o_fid_init/o_fid_fini
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 8fb73046ccaa6953a7202947ad70ebf63ee3dc7c

Gerrit Updater added a comment - 08/Jul/24 9:24 PM "Timothy Day <timday@amazon.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/55667 Subject: LU-18009 obd: remove o_fid_init/o_fid_fini Project: fs/lustre-release Branch: master Current Patch Set: 1 Commit: 8fb73046ccaa6953a7202947ad70ebf63ee3dc7c

People

Assignee:: Tim Day

Reporter:: Tim Day

Votes:: 0 Vote for this issue

Watchers:: 5 Start watching this issue

Dates

Created:: 08/Jul/24 9:22 PM

Updated:: 01/Apr/25 5:32 PM

Resolved:: 14/Feb/25 3:10 AM