[LU-18088] sanity-sec test_51: Error: 'chown f51.sanity-sec' (was LU-16915)

• Type: Bug
• Resolution: Fixed
• Priority: Minor
• Fix Version/s: Lustre 2.16.0
• Severity: 3
• Assignee: Vladimir Saveliev
• Reporter: Vladimir Saveliev

Description

vfs_getxattr() is not suitable for osd. To get security xattr it goes
via:

    vfs_getxattr
      xattr_getsecurity
        security_inode_getsecurity
          cap_inode_getsecurity
            dentry = d_find_any_alias(inode)
              if (!dentry)
                return -EINVAL;

and returns -EINVAL because osd object inodes have empty alias list.

So that on RHEL9 the following sequence of commands

touch /mnt/lustre/file
setcap CAP_CHOWN=ep /mnt/lustre/file
getfattr -d -n security.capability /mnt/lustre/file

fails with:

/mnt/lustre/file: security.capability: Invalid argument

Should be fixed by patch https://review.whamcloud.com/54072 "LU-17546 osd: use __vfs_removexattr".
However, there are still failures being hit with el9.2 and el9.3 servers during "full" test sessions with the latest master, so I don't think this is totally fixed.

This is because LU-17546 does not touch ll_vfs_getxattr, only ll_vfs_setxattr and ll_vfs_removexattr.

Issue Links

• is related to: LU-16915 sanity-sec test_51: Error: 'chown f51.sanity-sec'
• is related to: LU-17546 using vfs_setxattr() and vfs_removexattr() from within osd leads to a deadlock

Comments

[Peter Jones]

Merged for 2.16

[Gerrit Updater]

"Oleg Drokin <[e-mail]>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/55917/
Subject: LU-18088 osd: use __vfs_getxattr
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 215f1905cbaa0fadd6dee682c1f9c3782288c08c

[Gerrit Updater]

"Vladimir Saveliev <[e-mail]>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/55917
Subject: LU-18088 osd: use __vfs_getxattr
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 18181837935fe0256edf12217df422aae75a7396