Minor Description
There are many "command groups" like "lctl lfsck_start", "... lfsck_stop", "... lfsck_query" that would be better handled as subcommands like "lctl lfsck start", "lctl lfsck stop", etc. in the way that "lfs mirror create" and "lfs pcc attach" are implemented.
For lctl these include barrier_*, snapshot_*, lcfg_*, llog_*, nodemap_*, net_drop_*, net_delay_*, changelog_*, and for lfs it is only hsm_*.
Probably each one could be a separate patch. The old commands should be kept for compatibility, but the usage messages and man pages should all reference the new format.
The man page should be renamed, but there should also should be manpage .so link added for the old format of the command (with a "-" instead of a "_" in the name).
Attachments
Issue Links
Activity
"Oleg Drokin <green@whamcloud.com>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/56207/
Subject: LU-18114 nodemap: split "lctl nodemap_*" group into subcommands
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 75116202aa1977d0f94f05e2406cecfd24356124
"Oleg Drokin <green@whamcloud.com>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/57824/
Subject: LU-18114 tests: fix the version checks
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 6d9cfdeda92613f09eabd0b9f2f3402432691bc8
"Oleg Drokin <green@whamcloud.com>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/56328/
Subject: LU-18114 lfs: split "lfs hsm_*" group into subcommands
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 76d0eeea4fbc8fffb9cd6bae368eea19e09b6c17
"Emoly Liu <emoly@whamcloud.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/57824
Subject: LU-18114 tests: fix the version checks
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: af4149327a939fd68d78e0d0423f878fa20d6dcc
emoly.liu, can you please submit a patch to master to fix the version checks of the patches that just recently landed. They all had version checks for 2.15.6x but were landed after 2.16.50, so the interop testing is broken. Please include a Fixes: line for each of the patches, and "Test-Parameters: testlist=sanity serverversion=2.16".
Normally the exact version doesn't matter during testing, because we don't do interop testing against development tags (e.g. 2.15.63 or 2.15.64 is not critical), but in this case the patches landed after 2.16.50 and interop testing with 2.16.1 will be run repeatedly in the future and these checks need to be fixed.
"Oleg Drokin <green@whamcloud.com>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/56164/
Subject: LU-18114 lctl: split "lctl net_delay_*" group into subcommands
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: fec78d456815627d2afe5a75b85c11941f8e426a
"Oleg Drokin <green@whamcloud.com>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/56154/
Subject: LU-18114 lctl: split "lctl net_drop_*" group into subcommands
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 79a76faa48484cac10344137154ae93c16048d68
"Oleg Drokin <green@whamcloud.com>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/56133/
Subject: LU-18114 changelog: split "lctl changelog_*" group into subcommands
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 77e98c10b3ea5ff6c0664b9db138fa679817a986
"Oleg Drokin <green@whamcloud.com>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/56040/
Subject: LU-18114 llog: split "lctl llog_*" group into subcommands
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: fe4b49635d85fead1efbb4f06ac2c9e68ba76dfc