[LU-18117] Ubuntu 24.02 build fails with "no previous prototype for ‘llog_validate_record’"

• Type: Bug
• Resolution: Fixed
• Priority: Minor
• Fix Version/s: Lustre 2.16.0
• Affects Version/s: Lustre 2.16.0
• Labels: build
• Severity: 3
• Assignee: Sebastien Buisson
• Reporter: Sebastien Buisson

Description

After the latest batch of landings on master, Ubuntu 24.04 build fails with:

make[7]: Circular /var/lib/jenkins/workspace/lustre-reviews/arch/x86_64/build_type/client/distro/ubuntu2404/ib_stack/inkernel/BUILD/lustre-2.15.65_1_ga755b6a//modules.order <- /var/lib/jenkins/workspace/lustre-reviews/arch/x86_64/build_type/client/distro/ubuntu2404/ib_stack/inkernel/BUILD/lustre-2.15.65_1_ga755b6a/ dependency dropped.
  CC [M]  /var/lib/jenkins/workspace/lustre-reviews/arch/x86_64/build_type/client/distro/ubuntu2404/ib_stack/inkernel/BUILD/lustre-2.15.65_1_ga755b6a/lustre/fid/fid_request.o
  CC [M]  /var/lib/jenkins/workspace/lustre-reviews/arch/x86_64/build_type/client/distro/ubuntu2404/ib_stack/inkernel/BUILD/lustre-2.15.65_1_ga755b6a/lustre/obdclass/llog.o
  CC [M]  /var/lib/jenkins/workspace/lustre-reviews/arch/x86_64/build_type/client/distro/ubuntu2404/ib_stack/inkernel/BUILD/lustre-2.15.65_1_ga755b6a/lnet/lnet/api-ni.o
  CC [M]  /var/lib/jenkins/workspace/lustre-reviews/arch/x86_64/build_type/client/distro/ubuntu2404/ib_stack/inkernel/BUILD/lustre-2.15.65_1_ga755b6a/libcfs/libcfs/linux/linux-prim.o
  CC [M]  /var/lib/jenkins/workspace/lustre-reviews/arch/x86_64/build_type/client/distro/ubuntu2404/ib_stack/inkernel/BUILD/lustre-2.15.65_1_ga755b6a/lustre/ptlrpc/gss/sec_gss.o
/var/lib/jenkins/workspace/lustre-reviews/arch/x86_64/build_type/client/distro/ubuntu2404/ib_stack/inkernel/BUILD/lustre-2.15.65_1_ga755b6a/lustre/obdclass/llog.c:1541:5: error: no previous prototype for ‘llog_validate_record’ [-Werror=missing-prototypes]
 1541 | int llog_validate_record(const struct lu_env *env, struct llog_handle *llh,
      |     ^~~~~~~~~~~~~~~~~~~~

The patch that introduced this function is "LU-14714 mgc: server to mount without local config" https://review.whamcloud.com/55283 .

Issue Links

• is related to: LU-14714 allow starting with only MGS config log if local llog write fails

Comments

[Peter Jones]

Landed for 2.16

[Gerrit Updater]

"Andreas Dilger <[e-mail]>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/55964/
Subject: LU-18117 obdclass: fix llog_validate_record prototype
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: e390b5b00bbef3e253c6513e60b9fa630db584e9

[Gerrit Updater]

"Sebastien Buisson <[e-mail]>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/55964
Subject: LU-18117 obdclass: fix llog_validate_record prototype
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 35b123af9307f97778e57c30c2d7006bfd519d58