[LU-18141] Free'ing macros already check NULL

• Type: Task
• Resolution: Fixed
• Priority: Minor
• Fix Version/s: Lustre 2.16.0
• Severity: 3
• Assignee: Tim Day
• Reporter: Tim Day

Description

The common free'ing macros already check for NULL, so we don't need to explicitly check this beforehand.

@@
expression E;
@@
- if (E != NULL)
(
  OBD_FREE_PTR(E);
|
  OBD_FREE(E, ...);
|
  LIBCFS_FREE(E, ...);
|
  CFS_FREE_PTR(E);
|
  CFS_FREE_PTR_ARRAY(E, ...);
) 

Issue Links

• is related to: LU-18151 Example Coccinelle scripts for contrib/
• is related to: LU-6142 Enforce Linux kernel coding style in all code
• is related to: LU-16890 allow OBD_FREE() to ignore NULL pointers

Comments

[Peter Jones]

Seems like no 

[Peter Jones]

All existing patches seem to have merged for 2.16. Are there more to come?

[Gerrit Updater]

"Oleg Drokin <[e-mail]>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/56042/
Subject: LU-18141 obdclass: don't check for NULL before free'ing
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: ffe9424e4274d310104bd5fe68dc5a694c3e81df

[Gerrit Updater]

"Oleg Drokin <[e-mail]>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/56051/
Subject: LU-18141 obd: remove OBD_SLAB_FREE_RTN0()
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: bd73e2326a6f24a2b6e05655400293a54e911128

[Gerrit Updater]

"Oleg Drokin <[e-mail]>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/56049/
Subject: LU-18141 misc: (for l*) don't check NULL before free'ing
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 702cffaa1bd2fb2d430f2af7994834b4225ea6fe

[Gerrit Updater]

"Oleg Drokin <[e-mail]>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/56048/
Subject: LU-18141 misc: (for [mf]*) don't check NULL before free'ing
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: e0aeb99bbf8806fabd29e14de0131266ad440320

[Gerrit Updater]

"Oleg Drokin <[e-mail]>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/56047/
Subject: LU-18141 misc: (for o*) don't check for NULL before free'ing
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 4effc77c193dd15b9c440227838fbf3271456a72

[Gerrit Updater]

"Oleg Drokin <[e-mail]>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/56046/
Subject: LU-18141 ptlrpc: don't check for NULL before free'ing
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 307f98e21fdcb376585f8db76e4d3727f1fa7a1a

[Gerrit Updater]

"Oleg Drokin <[e-mail]>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/56045/
Subject: LU-18141 mdt: don't check for NULL before free'ing
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 8fb94c0a644a0f78e980d520a03d4b6fd95d07c2

[Gerrit Updater]

"Oleg Drokin <[e-mail]>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/56044/
Subject: LU-18141 osd: don't check for NULL before free'ing
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: de37968c8c3be7dab31754728d859102dd5258b1