[LU-18210] sanityn test 113: fails with cannot find mgc of nid

• Type: Bug
• Resolution: Fixed
• Priority: Minor
• Fix Version/s: Lustre 2.17.0
• Severity: 3
• Assignee: Chris Horn
• Reporter: Chris Horn

Description

static int get_root_path_slow(int want, char *fsname, int *outfd, char *path,
                              int index, dev_t *dev, char *nid)
{
...
                ptr_end = strchr(mnt.mnt_fsname, ':');
                strncpy(root_cached.nid, mnt.mnt_fsname,
                        ptr_end - mnt.mnt_fsname);
                root_cached.nid[ptr_end - mnt.mnt_fsname] = '\0';
...

This logic doesn't handle IPv6 NIDs correctly.

Issue Links

• is related to: LU-18417 Finish IPv6 support
• is related to: LU-18041 struct obd_uuid is too small for MGC"NID" uuid

Comments

[Peter Jones]

Merged for 2.17

[Gerrit Updater]

"Oleg Drokin <[e-mail]>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/56286/
Subject: LU-18210 utils: Fix issues with enhanced 'lfs check'
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 170a0b204b03e314cfc69ab26477499592c0e43e

[Gerrit Updater]

"Chris Horn <[e-mail]>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/56286
Subject: LU-18210 utils: Fix issues with enhanced 'lfs check'
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: baf31f6eb886dd133ef486494bf794dcba706bf6

[Chris Horn]

This is a problem with

commit f5ca6853b8d8b918b0228af31fa8249be49d3000
Author: Lei Feng <[e-mail]>
Date:   Mon Aug 8 10:59:25 2022 +0800

    LU-16076 utils: enhance 'lfs check' command

    Add optional argument to 'lfs check' command so that only the
    servers related to the specified lustre file system is checked.

The code has a couple issues:
1) It doesn't handle IPv6 NIDs correctly
2) It doesn't handle case where multiple NIDs are listed on mount command separated by commas
3) It assumes that the NID parsed out of the filesystem name will be the one that we're actually connected on

[James A Simmons]

I have a patch to expand the obd_name. https://review.whamcloud.com/#/c/fs/lustre-release/+/55818 .Maybe that will solve this.