Uploaded image for project: 'Lustre'
  1. Lustre
  2. LU-18333

lfs.c has executable attribute bit

Details

    • Bug
    • Resolution: Fixed
    • Minor
    • Lustre 2.17.0
    • None
    • 3
    • 9223372036854775807

    Description

      Somehow lustre/utils/lfs.c has executable mode bit, which does not cause any problem yet, but cause warning when building:

      *** WARNING: ./usr/src/lustre-ldiskfs-2.15.91/lustre/utils/lfs.c is executable but has no shebang, removing executable bit

      Attachments

        Issue Links

          is related to

          Improvement - An improvement or enhancement to an existing feature or task. LU-17516 add 'lfs df --mdt' and 'lfs df --ost' options

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Resolved

          Activity

            [LU-18333] lfs.c has executable attribute bit
            pjones Peter Jones added a comment -

            Merged for 2.17

            pjones Peter Jones added a comment - Merged for 2.17
            gerrit Gerrit Updater added a comment -

            "Oleg Drokin <green@whamcloud.com>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/58889/
            Subject: LU-18333 target: Remove executable bit from lfs.c
            Project: fs/lustre-release
            Branch: master
            Current Patch Set:
            Commit: e40c981e0f795fef8701056faf13d4e58316ab42

            gerrit Gerrit Updater added a comment - "Oleg Drokin <green@whamcloud.com>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/58889/ Subject: LU-18333 target: Remove executable bit from lfs.c Project: fs/lustre-release Branch: master Current Patch Set: Commit: e40c981e0f795fef8701056faf13d4e58316ab42
            gerrit Gerrit Updater added a comment -

            "Aryan Gupta <argupta@ddn.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/58889
            Subject: LU-18333 target: Remove executable bit from lfs.c
            Project: fs/lustre-release
            Branch: master
            Current Patch Set: 1
            Commit: 0650ce5aefe5073aa9156aba757f65f8d1351ff4

            gerrit Gerrit Updater added a comment - "Aryan Gupta <argupta@ddn.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/58889 Subject: LU-18333 target: Remove executable bit from lfs.c Project: fs/lustre-release Branch: master Current Patch Set: 1 Commit: 0650ce5aefe5073aa9156aba757f65f8d1351ff4
            cfaber Colin Faber added a comment -

            Hi argupta can you please take a look? Thank you!

            cfaber Colin Faber added a comment - Hi argupta can you please take a look? Thank you!
            adilger Andreas Dilger added a comment -

            Should get:

            Fixes: 1631c5728b ("LU-17516 utils: new --mdt and --ost options for lfs df")

            This is caused by editing files inside VirtualBox with vboxsf, since it doesn't preserve permissions/mode.

            Possibly an addition to checkpatch.pl that looks for the executable bit set?

            adilger Andreas Dilger added a comment - Should get: Fixes: 1631c5728b ("LU-17516 utils: new --mdt and --ost options for lfs df") This is caused by editing files inside VirtualBox with vboxsf, since it doesn't preserve permissions/mode. Possibly an addition to checkpatch.pl that looks for the executable bit set?

            People

              argupta Aryan Gupta
              lixi_wc Li Xi
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: