Uploaded image for project: 'Lustre'
  1. Lustre
  2. LU-18359

Do not escape "..." around jobid_name

Details

    • Improvement
    • Resolution: Unresolved
    • Minor
    • None
    • Lustre 2.14.0
    • 3
    • 9223372036854775807

    Description

      If the jobid name is specified with "..." around it already, the " characters are considered unprintable and hex-escaped, resulting in a double-eacaped jobid:

      jobid_name="%H:%e:%u"
job_stats:
- job_id:          "\x22twoshoes:lfs:0\x22"

      where "\x22" is the hex code for ".

      If the jobid_name is sent to the server with "..." around it already, they should not be escaped and more quotes added.

      If the jobid_name is set on the client with " around it, these could be stripped from the name so that there is more space to send useful information, and they will be added on the server again.

      For compatibility, servers that receive a jobid with " around it should drop that when printing the job_stats. Checking and dropping it for every RPC that is processed adds overhead and does not increase the available size of the jobid itself.

      Attachments

        Issue Links

          is related to

          Bug - A problem which impairs or prevents the functions of the product. LU-18798 user.job xattr is storing quotes around job name

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Open

          Improvement - An improvement or enhancement to an existing feature or task. LU-11407 Improve stats data

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Resolved

          Improvement - An improvement or enhancement to an existing feature or task. LU-16555 print more YAML compatible special chars for jobid

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Resolved

          Activity

            [LU-18359] Do not escape "..." around jobid_name
            adilger Andreas Dilger made changes -
            Link New: This issue is related to LU-18798 [ LU-18798 ]
            adilger Andreas Dilger added a comment -

            LU-18798 is tracking to remove the "" around the jobname in the xattr, while this ticket is avoiding to print the jobname with an extra layer of quotes.

            adilger Andreas Dilger added a comment - LU-18798 is tracking to remove the "" around the jobname in the xattr, while this ticket is avoiding to print the jobname with an extra layer of quotes.
            adilger Andreas Dilger made changes -
            Labels Original: easy kernel New: easy
            adilger Andreas Dilger made changes -
            Labels Original: easy New: easy kernel
            adilger Andreas Dilger made changes -
            Description Original: If the jobid name is specified with {{"..."}} around it already, the {{"}} characters are considered unprintable and hex-escaped, resulting in a double-eacaped jobid:
            {noformat}
            jobid_name="%H:%e:%u"
            job_stats:
            - job_id: "\x22twoshoes:lfs:0\x22"
            {noformat}
            where "{{\x22}}" is the hex code for {{"}}.
             
            If the {{jobid_name}} is sent to the server with {{"..."}} around it already, they should not be escaped and more quotes added.

            If the {{jobid_name}} is set on the client with {{"}} around it, these could be stripped from the name so that there is more space to send useful information, and they will be added on the server again.             		New: If the jobid name is specified with {{"..."}} around it already, the {{"}} characters are considered unprintable and hex-escaped, resulting in a double-eacaped jobid:
            {noformat}
            jobid_name="%H:%e:%u"
            job_stats:
            - job_id: "\x22twoshoes:lfs:0\x22"
            {noformat}
            where "{{\x22}}" is the hex code for {{"}}.
             
            If the {{jobid_name}} is sent to the server with {{"..."}} around it already, they should not be escaped and more quotes added.

            If the {{jobid_name}} is set on the client with {{"}} around it, these could be stripped from the name so that there is more space to send useful information, and they will be added on the server again.

            For compatibility, servers that receive a jobid with {{"}} around it should drop that when printing the {{job_stats}}. Checking and dropping it for every RPC that is processed adds overhead and does not increase the available size of the jobid itself.
            adilger Andreas Dilger made changes -
            Description Original: If the jobid name is specified with {{"..."}} around it already, the {{"}} characters are considered unprintable and hex-escaped, resulting in a double-eacaped jobid:
            {noformat}
            jobid_name="%H:%e:%u"
            job_stats:
            - job_id: "\x22twoshoes:lfs:0\x22"
            {noformat}
            where "{{\\\x22}}" is the hex code for {{"}}.
             
            If the {{jobid_name}} is sent to the server with {{"..."}} around it already, they should not be escaped and more quotes added.

            If the {{jobid_name}} is set on the client with {{"}} around it, these could be stripped from the name so that there is more space to send useful information, and they will be added on the server again.             		New: If the jobid name is specified with {{"..."}} around it already, the {{"}} characters are considered unprintable and hex-escaped, resulting in a double-eacaped jobid:
            {noformat}
            jobid_name="%H:%e:%u"
            job_stats:
            - job_id: "\x22twoshoes:lfs:0\x22"
            {noformat}
            where "{{\x22}}" is the hex code for {{"}}.
             
            If the {{jobid_name}} is sent to the server with {{"..."}} around it already, they should not be escaped and more quotes added.

            If the {{jobid_name}} is set on the client with {{"}} around it, these could be stripped from the name so that there is more space to send useful information, and they will be added on the server again.
            adilger Andreas Dilger made changes -
            Description Original: If the jobid name is specified with {{"..."}} around it already, the {{"}} characters are considered unprintable and hex-escaped, resulting in a double-eacaped jobid:
            {noformat}
            jobid_name="%H:%e:%u"
            job_stats:
            - job_id: "\x22twoshoes:lfs:0\x22"
            {noformat}
            where "{{\\x22}}" is the hex code for {{"}}.

            If the {{jobid_name}} is sent to the server with {{"..."}} around it already, they should not be escaped and more quotes added.

            If the {{jobid_name}} is set on the client with {{"}} around it, these could be stripped from the name so that there is more space to send useful information, and they will be added on the server again.             		New: If the jobid name is specified with {{"..."}} around it already, the {{"}} characters are considered unprintable and hex-escaped, resulting in a double-eacaped jobid:
            {noformat}
            jobid_name="%H:%e:%u"
            job_stats:
            - job_id: "\x22twoshoes:lfs:0\x22"
            {noformat}
            where "{{\\\x22}}" is the hex code for {{"}}.
             
            If the {{jobid_name}} is sent to the server with {{"..."}} around it already, they should not be escaped and more quotes added.

            If the {{jobid_name}} is set on the client with {{"}} around it, these could be stripped from the name so that there is more space to send useful information, and they will be added on the server again.
            adilger Andreas Dilger made changes -
            Link New: This issue is related to LU-11407 [ LU-11407 ]
            adilger Andreas Dilger made changes -
            Link Original: This issue is related to LU-7187 [ LU-7187 ]
            adilger Andreas Dilger made changes -
            Link New: This issue is related to LU-7187 [ LU-7187 ]
            adilger Andreas Dilger made changes -
            Link New: This issue is related to LU-16555 [ LU-16555 ]

            People

              wc-triage WC Triage
              adilger Andreas Dilger
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated: