[LU-18445] Sleeping before panic in LBUG is wrong

• Type: Bug
• Resolution: Fixed
• Priority: Major
• Fix Version/s: Lustre 2.17.0
• Affects Version/s: Lustre 2.16.0, Lustre 2.17.0
• Severity: 3
• Assignee: Oleg Drokin
• Reporter: Oleg Drokin

Description

patch https://review.whamcloud.com/c/fs/lustre-release/+/55505 introduced a sleeping before panic on lbug, this is actually a bad idea:

it pollutes the logs with useless data (both lustre and dmesg) and makes sure all sorts of tight races disappear from threads in the crashdump.

This msleep needs to be removed.

Issue Links

• is related to: LU-17793 warning: objtool: __cfs_fail_check_set() falls through to next function __cfs_fail_timeout_set()

Comments

[Peter Jones]

Merged for 2.17

[Gerrit Updater]

"Oleg Drokin <[e-mail]>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/57010/
Subject: LU-18445 libcfs: Remove msleep before panic for lbug
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 83f62e0dee9447919b7fbcf60eea0e6b0c503930

[Gerrit Updater]

"Oleg Drokin <[e-mail]>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/57010
Subject: LU-18445 libcfs: Remove msleep before panic for lbug
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 4fcfc789401fedf82709204daa9a478319bbc837