Uploaded image for project: 'Lustre'
  1. Lustre
  2. LU-18445

Sleeping before panic in LBUG is wrong

Details

    • Bug
    • Resolution: Fixed
    • Major
    • Lustre 2.17.0
    • Lustre 2.16.0, Lustre 2.17.0
    • None
    • 3
    • 9223372036854775807

    Description

      patch https://review.whamcloud.com/c/fs/lustre-release/+/55505 introduced a sleeping before panic on lbug, this is actually a bad idea:

      it pollutes the logs with useless data (both lustre and dmesg) and makes sure all sorts of tight races disappear from threads in the crashdump.

      This msleep needs to be removed.

      Attachments

        Issue Links

          is related to

          Bug - A problem which impairs or prevents the functions of the product. LU-17793 warning: objtool: __cfs_fail_check_set() falls through to next function __cfs_fail_timeout_set()

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Resolved

          Activity

            [LU-18445] Sleeping before panic in LBUG is wrong
            pjones Peter Jones made changes -
            Link Original: This issue is related to JFC-21 [ JFC-21 ]
            pjones Peter Jones made changes -
            Link New: This issue is related to JFC-21 [ JFC-21 ]
            pjones Peter Jones made changes -
            Fix Version/s New: Lustre 2.17.0 [ 16192 ]
            Resolution New: Fixed [ 1 ]
            Status Original: Open [ 1 ] New: Resolved [ 5 ]
            pjones Peter Jones added a comment -

            Merged for 2.17

            pjones Peter Jones added a comment - Merged for 2.17
            gerrit Gerrit Updater added a comment -

            "Oleg Drokin <green@whamcloud.com>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/57010/
            Subject: LU-18445 libcfs: Remove msleep before panic for lbug
            Project: fs/lustre-release
            Branch: master
            Current Patch Set:
            Commit: 83f62e0dee9447919b7fbcf60eea0e6b0c503930

            gerrit Gerrit Updater added a comment - "Oleg Drokin <green@whamcloud.com>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/57010/ Subject: LU-18445 libcfs: Remove msleep before panic for lbug Project: fs/lustre-release Branch: master Current Patch Set: Commit: 83f62e0dee9447919b7fbcf60eea0e6b0c503930
            pjones Peter Jones made changes -
            Link New: This issue is related to LU-17793 [ LU-17793 ]
            pjones Peter Jones made changes -
            Assignee Original: WC Triage [ wc-triage ] New: Oleg Drokin [ green ]
            gerrit Gerrit Updater added a comment -

            "Oleg Drokin <green@whamcloud.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/57010
            Subject: LU-18445 libcfs: Remove msleep before panic for lbug
            Project: fs/lustre-release
            Branch: master
            Current Patch Set: 1
            Commit: 4fcfc789401fedf82709204daa9a478319bbc837

            gerrit Gerrit Updater added a comment - "Oleg Drokin <green@whamcloud.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/57010 Subject: LU-18445 libcfs: Remove msleep before panic for lbug Project: fs/lustre-release Branch: master Current Patch Set: 1 Commit: 4fcfc789401fedf82709204daa9a478319bbc837
            green Oleg Drokin created issue -

            People

              green Oleg Drokin
              green Oleg Drokin
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: