[LU-18488] correct the strange use of llapi_resync_comp::lrc_synced

• Type: Improvement
• Resolution: Fixed
• Priority: Minor
• Fix Version/s: Lustre 2.17.0
• Severity: 3
• Assignee: Zhenyu Xu
• Reporter: Zhenyu Xu

Description

llapi_resync_comp::lrc_synced is used against intuitive in the mirror resync code.

llapi_mirror_resync_many_params()

                        written = llapi_mirror_write(fd,                            
                                        comp_array[i].lrc_mirror_id,                
                                        buf + pos2 - pos,                           
                                        to_write2, pos2);                           
                        if (written < 0) {                                          
                                /**                                                 
                                 * this component is not written successfully,  
                                 * mark it using its lrc_synced, it is supposed                                                          
                                 * to be false before getting here.                 
                                 *                                                  
                                 * And before this function returns, all            
                                 * elements of comp_array will reverse their    
                                 * lrc_synced flag to reflect their true            
                                 * meanings.                                        
                                 */                                                 
                                comp_array[i].lrc_synced = true;    

Comments

[Peter Jones]

Merged for 2.17

[Gerrit Updater]

"Oleg Drokin <[e-mail]>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/57137/
Subject: LU-18488 utils: make lrc_synced usage intuitive
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 402232444a08ec4dda3a6c6818c3888cf562fbfc

[Gerrit Updater]

"Zhenyu Xu <[e-mail]>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/57137
Subject: LU-18488 utils: make lrc_synced usage intuitive
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: b93f14f8f808f2ab0676bd34e0fafa401d8ee05a