[LU-18516] do not call blocking ops when !TASK_RUNNING occurs in osd-ldisk / quota path

• Type: Bug
• Resolution: Fixed
• Priority: Minor
• Fix Version/s: Lustre 2.17.0
• Affects Version/s: Lustre 2.17.0
• Labels: janitor9x
• Environment: Lustre 2.17 runnning ldiskfs with a debug kernel.
• Severity: 3
• Assignee: James A Simmons
• Reporter: James A Simmons

Description

With a debug kernel for sanity-quota test  1i reports the following:

[ 1276.935753] ------------[ cut here ]------------ 
[ 1276.937120] do not call blocking ops when !TASK_RUNNING; state=402 set at [<00000000ccd913e0>] prepare_to_wait_event+0xc9/0x2a0 
[ 1276.939652] WARNING: CPU: 2 PID: 15740 at kernel/sched/core.c:6733 __might_sleep+0xa3/0xc0 
[ 1276.952941] CPU: 2 PID: 15740 Comm: ll_ost_io00_003 4.18.0rh8.5-debug #2 
[ 1276.955682] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.16.2-1.fc38 04/01/2014 
[ 1276.957525] RIP: 0010:__might_sleep+0xa3/0xc0 

Call Trace:
[ 1276.976327] down_read_nested+0x2e/0x430
[ 1276.977082] osd_read_lock+0xc8/0x180 [osd_ldiskfs]
[ 1276.977957] lquota_disk_read+0x8e/0x540 [lquota] 
[ 1276.978994] qsd_refresh_usage+0x105/0x3d0 [lquota] 
[ 1276.979956] qsd_acquire+0xbe/0x770 [lquota] 
[ 1276.980753] qsd_op_begin0+0x5f8/0xd60 [lquota] 
[ 1276.983353] qsd_op_begin+0x3fa/0x6d0 [lquota] 
[ 1276.984720] osd_declare_qid+0x4da/0x770 [osd_ldiskfs] 
[ 1276.985625] osd_declare_inode_qid+0x14f/0x630 [osd_ldiskfs] 
[ 1276.986723] osd_declare_write_commit+0x810/0xaa0 [osd_ldiskfs] 
[ 1276.988811] ofd_commitrw_write+0x60e/0x2010 [ofd] 
[ 1276.989579] ofd_commitrw+0x838/0x15d0 [ofd] 
[ 1276.991503] tgt_brw_write+0x19ab/0x3780 [ptlrpc] 
[ 1276.993689] tgt_handle_request0+0x13c/0xb00 [ptlrpc] 
[ 1276.994614] tgt_request_handle+0x351/0x1c10 [ptlrpc]
[ 1276.995676] ptlrpc_server_handle_request+0x379/0x1320 [ptlrpc]
[ 1276.997827] ptlrpc_main+0xd58/0x1500 [ptlrpc]

Issue Links

• is related to: LU-18980 do not call blocking ops when !TASK_RUNNING; state=402 set at [<0000000078a4a089>] prepare_to_wait_event+0x90/0x1a0
• is related to: LU-16807 Resolve newer debug kernel warnings

Comments

[Peter Jones]

Merged for 2.17

[Gerrit Updater]

"Oleg Drokin <[e-mail]>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/58156/
Subject: LU-18516 quota: use wait_woken for qsd_op_begin0()
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 2417aeddc649840179a2575a28fdedf3fe662916

[Gerrit Updater]

"James Simmons <[e-mail]>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/58156
Subject: LU-18516 quota: use wait_woken for qsd_op_begin0()
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: ba069d485ab82c2f226c51b6335dc28110249e00