[LU-18609] use of logical '&&' with constant operand

• Type: Bug
• Resolution: Fixed
• Priority: Major
• Fix Version/s: Lustre 2.17.0
• Severity: 3
• Assignee: Zhenyu Xu
• Reporter: Zhenyu Xu

Description

the latest report on new defect(s) introduced to Lustre found with Coverity Scan.

• • CID 454269: (CONSTANT_EXPRESSION_RESULT)

/lustre/osc/osc_cache.c: 2048 in get_read_extents()
CID 454269: (CONSTANT_EXPRESSION_RESULT)
The expression "!!ldlm_lock_to_ns(__ext->oe_dlmlock)->ns_dump_stack_on_error && 1 /* D_ERROR & D_ERROR */" is suspicious because it performs a Boolean operation on a constant other than 0 or 1.
2048 EASSERT(ext->oe_nr_pages <= data.erd_max_pages, ext);

Some new gcc would report warning: use of logical '&&' with constant operand [-Wconstant-logical-operand]