[LU-18664] distribute_txn_commit_batchid_update() is called in an atomic context

• Type: Bug
• Resolution: Unresolved
• Priority: Minor
• Affects Version/s: Lustre 2.17.0
• Labels: janitor9x
• Environment: RHEL8 running with debug kernel.
• Severity: 3
• Assignee: James A Simmons
• Reporter: James A Simmons

Description

The function distribute_txn_commit_batchid_update() is called in an atomic context and its memory allocation is using the wrong flags so it could sleep.

[ 438.069480] Lustre: DEBUG MARKER: == sanity test 60g: transaction abort won't cause MDT hung ========================================================== 01:29:59 (1737268199) [ 438.778260] Lustre: *** cfs_fail_loc=19a, val=0*** [ 438.779722] -----------[ cut here ]----------- [ 438.780791] do not call blocking ops when !TASK_RUNNING; state=402 set at [<00000000878da86f>] distribute_txn_commit_thread+0x98/0x1020 [ptlrpc] [ 438.784185] WARNING: CPU: 0 PID: 11190 at kernel/sched/core.c:7471 _might_sleep+0x9d/0xc0 [ 438.787200] Modules linked in: zfs(O) spl(O) lustre(O) osp(O) ofd(O) lod(O) mdt(O) mdd(O) mgs(O) osd_ldiskfs(O) ldiskfs(O) lquota(O) lfsck(O) obdecho(O) mgc(O) mdc(O) lov(O) osc(O) lmv(O) fid(O) fld(O) ptlrpc_gss(O) ptlrpc(O) obdclass(O) ksocklnd(O) lnet(O) libcfs(O) dm_flakey rpcsec_gss_krb5 auth_rpcgss nfsv4 dns_resolver intel_rapl_msr intel_rapl_common sb_edac rapl pcspkr i2c_piix4 squashfs crct10dif_pclmul crc32_pclmul crc32c_intel ata_generic ghash_clmulni_intel serio_raw ata_piix libata dm_mirror dm_region_hash dm_log dm_mod sha512_ssse3 sha512_generic [ 438.802398] CPU: 0 PID: 11190 Comm: dist_txn-1 Kdump: loaded Tainted: G W O -------- - - 4.18.0rh8.10-debug #7 [ 438.805087] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.16.2-1.fc38 04/01/2014 [ 438.807736] RIP: 0010:_might_sleep+0x9d/0xc0 [ 438.809222] Code: b0 1f 00 00 48 c7 c7 40 30 b9 a9 48 83 05 da f0 29 03 01 c6 05 6f ff 7e 02 01 48 89 d1 e8 97 01 fb ff 48 83 05 cb f0 29 03 01 <0f> 0b 48 83 05 c9 f0 29 03 01 48 83 05 c9 f0 29 03 01 eb 9b 66 66 [ 438.813555] RSP: 0018:ffffb2e14843bd78 EFLAGS: 00010202 [ 438.814543] RAX: 0000000000000000 RBX: ffffffffa9bc0c83 RCX: 0000000000000000 [ 438.815867] RDX: ffff99fd013ef040 RSI: ffff99fd013de808 RDI: ffff99fd013de808 [ 438.817904] RBP: 00000000000000e2 R08: 0000000000000000 R09: c0000000ffff7fff [ 438.819690] R10: 0000000000000001 R11: ffffb2e14843bb68 R12: 0000000000000000 [ 438.821715] R13: 0000000000000001 R14: 0000000000000058 R15: ffffffffc0d70998 [ 438.823532] FS: 0000000000000000(0000) GS:ffff99fd01200000(0000) knlGS:0000000000000000 [ 438.826276] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [ 438.828290] CR2: 00007f0dc211a000 CR3: 000000013b228006 CR4: 0000000000170ef0 [ 438.830346] Call Trace: [ 438.830783] ? show_regs.cold.9+0x22/0x2f [ 438.831512] ? __warn+0xc8/0x150 [ 438.832101] ? __might_sleep+0x9d/0xc0 [ 438.832683] ? report_bug+0x113/0x140 [ 438.833334] ? do_error_trap+0xb6/0x130 [ 438.834184] ? do_invalid_op+0x46/0x60 [ 438.834822] ? __might_sleep+0x9d/0xc0 [ 438.835435] ? invalid_op+0x14/0x20 [ 438.836600] ? distribute_txn_commit_batchid_update+0x68/0xa90 [ptlrpc] [ 438.839309] ? __might_sleep+0x9d/0xc0 [ 438.840813] ? __might_sleep+0x95/0xc0 [ 438.842316] slab_pre_alloc_hook.constprop.59+0x13d/0x1f0 [ 438.844455] kmem_cache_alloc_trace+0x5b/0x380 [ 438.846316] ? kfree+0x3bb/0x3d0 [ 438.848095] distribute_txn_commit_batchid_update+0x68/0xa90 [ptlrpc] [ 438.851387] distribute_txn_commit_thread+0xab5/0x1020 [ptlrpc] [ 438.854626] ? distribute_txn_commit_batchid_update+0xa90/0xa90 [ptlrpc] [ 438.857958] kthread+0x1d7/0x210 [ 438.859439] ? set_kthread_struct+0x70/0x70 [ 438.861328] ret_from_fork+0x1f/0x30

Issue Links

• is related to: LU-16807 Resolve newer debug kernel warnings