[LU-18751] Segfault in lnetctl fault command

• Type: Bug
• Resolution: Fixed
• Priority: Minor
• Fix Version/s: Lustre 2.17.0
• Severity: 3
• Assignee: Frank Sehr
• Reporter: Frank Sehr

Description

Lnet ctl cors with the command "lnetctl fault reset \0"

Comments

[Andreas Dilger]

This generated a new Coverity warning in the latest run:

CID 458333: Null pointer dereferences (REVERSE_INULL)
/lnet/utils/lnetconfig/liblnetconfig.c: 955 in infra_ping_nid():

949                 id.pid = LNET_PID_ANY;
950                 /* if no net is specified, libcfs_str2nid() will assume tcp */
951                 id.nid = libcfs_str2nid(token);
952                 if (id.nid == LNET_NID_ANY) {
953                     snprintf(err_str, sizeof(err_str),
954                          "\"cannot parse NID '%s'\"",

CID 458333: Null pointer dereferences (REVERSE_INULL)
Null-checking "token" suggests that it may be null, but it has already been dereferenced on all paths leading to the check.

955                          token ? token : "NULL");
956                     rc = LUSTRE_CFG_RC_BAD_PARAM;
957                     cYAML_build_error(rc, seq_no, MANAGE_CMD,
958                               oper, err_str, err_rc);
959                     continue;
960                 }

[Peter Jones]

Merged for 2.17

[Gerrit Updater]

"Oleg Drokin <[e-mail]>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/58376/
Subject: LU-18751 lnet: fix sanity-lnet/410 test case
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: dc54ff33100d91912c2857523d59ce00022becc3

[Gerrit Updater]

"Frank Sehr <[e-mail]>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/58376
Subject: LU-18751 lnet: fix sanity-lnet/410 test case
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: c4c6d1103001c09f40b004820767d2ea65e67e8d

[Andreas Dilger]

The new test_410 is failing regularly on master in the week since it has landed:
https://testing.whamcloud.com/search?status%5B%5D=FAIL&test_set_script_id=a2b1c4b2-b449-11e9-b88c-52540065bddc&sub_test_script_id=8a1b5580-eb55-4d81-ad10-2ae95c357140&start_date=2025-02-01&end_date=2025-03-10&source=sub_tests#redirect

== sanity-lnet test 410: No segfault in lnetctl fault command ==== 07:26:42 (1741505202)
/usr/sbin/lnetctl lnet unconfigure
/usr/sbin/lnetctl lnet configure
/usr/sbin/lnetctl fault reset 0
 sanity-lnet test_410: @@@@@@ FAIL: Command should fail 

[Gerrit Updater]

"Oleg Drokin <[e-mail]>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/58216/
Subject: LU-18751 lnet: Segfault in lnetctl fault command
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 30868de94003ae436d7177b92e22553c22f54b9f

[Gerrit Updater]

"Frank Sehr <[e-mail]>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/58216
Subject: LU-18751 lnet: Segfault in lnetctl fault command
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 37cd4845f819d05e86ba1489652b248aa2dbaed3