[LU-18871] "which: no ofed_info in ..." message from lustre-client-dkms causes frequent confusion

• Type: Improvement
• Resolution: Fixed
• Priority: Minor
• Fix Version/s: Lustre 2.17.0
• Severity: 3
• Assignee: Shaun Tancheff
• Reporter: Shaun Tancheff

Description

"which: no ofed_info in ..." message from lustre-client-dkms causes frequent confusion

The construct is seen in a few places and leaks via stderr when ofed_info does not exist.

if which ofed_info >/dev/null ; then

This causes confusion among users that are not using MOFED.

This can be quashed by adding the redirect of stderr to /dev/null or using `command -v` to get the same effect.

Comments

[Peter Jones]

Merged for 2.17

[Gerrit Updater]

"Oleg Drokin <[e-mail]>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/58594/
Subject: LU-18871 dkms: prefer 'command -v' over 'which'
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 103da50d673900b53b1b6c635133b12280b37647

[Gerrit Updater]

"Shaun Tancheff <[e-mail]>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/58594
Subject: LU-18871 dkms: prefer 'command -v' over 'which'
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: b245e9feec8a03569b9a431a650d7a0725ac5234