[LU-18994] Null pointer deerference in lov_add_mgc_target

• Type: Bug
• Resolution: Unresolved
• Priority: Minor
• Fix Version/s: Lustre 2.17.0
• Affects Version/s: Lustre 2.17.0
• Labels: smatch
• Severity: 3
• Assignee: WC Triage
• Reporter: Oleg Drokin

Description

smatch highlights this issue in lov_add_mdc_target() :

             if (!lmv_obd) {
                       CERROR("%s: cannot find LMV OBD by UUID (%s)\n",
                              lov_obd->obd_name,
                              obd_uuid2str(&lmv_obd->obd_uuid));
                       RETURN(-ENODEV);

lmv_obd is clearly NULL here, so attempting to print uuid of i would result in a crash.

It's likely this condition was never hit, but I am not sure if it's jus ta typo and we wanted uuid of the lov_obd together with the name, or if we need to drop it altogether.