[LU-18999] chlg_obd_get() does not unlock semaphore on error path

• Type: Bug
• Resolution: Duplicate
• Priority: Minor
• Fix Version/s: Lustre 2.18.0
• Affects Version/s: Lustre 2.17.0
• Labels: smatch
• Severity: 3
• Assignee: Hongchao Zhang
• Reporter: Oleg Drokin

Description

High;ighted by smatch, introduced in https://review.whamcloud.com/35784

static inline struct obd_device* chlg_obd_get(struct chlg_registered_dev *dev)
{
        struct obd_device *obd;
        mutex_lock(&chlg_registered_dev_lock);
        if (list_empty(&dev->ced_obds))
                return NULL;
        obd = list_first_entry(&dev->ced_obds, struct obd_device,
                               u.cli.cl_chg_dev_linkage);
        class_incref(obd, "changelog", dev);
        mutex_unlock(&chlg_registered_dev_lock);
        return obd;
}

Looks like we need to unlock that semaphore.

 

Issue Links

• is duplicated by: LU-19860 Missing mutex_unlock in chlg_obd_get() error path causes deadlock
• is related to: LU-11626 mdc: obd might go away while referenced by code in mdc_changelog