[LU-19001] osp_create uses likely wrongly

• Type: Bug
• Resolution: Unresolved
• Priority: Minor
• Fix Version/s: Lustre 2.17.0
• Affects Version/s: Lustre 2.17.0
• Labels: easy smatch
• Severity: 3
• Assignee: WC Triage
• Reporter: Oleg Drokin

Description

smatch highlights that osp_create uses likely() wrongly:

        /* we might have lost precreated objects */
        if (unlikely(d->opd_gap_count) > 0) {

where as it clearly should be if (unlikely(d->opd_gap_count > 0))

Introduced in http://review.whamcloud.com/4030