Uploaded image for project: 'Lustre'
  1. Lustre
  2. LU-1902

disable sanity-quota.sh for OFD on 2.3

Details

    • Bug
    • Resolution: Won't Fix
    • Major
    • None
    • Lustre 2.3.0, Lustre 2.4.0
    • 3
    • 5141

    Description

      This issue was created by maloo for Andreas Dilger <adilger@whamcloud.com>

      This issue relates to the following test suite run: https://maloo.whamcloud.com/test_sets/ec6c56cc-f9ba-11e1-b8d8-52540035b04c.

      Looking at the test output for a ZFS test run with USE_OFD=yes, it seems that there is some simple check needed in order to disable quota testing with OFD:

      11:48:38:CMD: client-19vm4 lctl set_param lquota.lustre-OST*.stats=0
      11:48:38:client-19vm4: error: set_param: /proc/{fs,sys}/{lnet,lustre}/lquota/lustre-OST*/stats: Found no match
      

      I suspect the same will be true for ldiskfs-backed OFD tests as well.

      This needs to be the case for USE_OFD=yes until the orion quota project has finished landing.

      Attachments

        Activity

          [LU-1902] disable sanity-quota.sh for OFD on 2.3

          This is no longer needed.

          adilger Andreas Dilger added a comment - This is no longer needed.

          Minh, USE_OFD is obsolete now and test_33() in master do have syc_all_data after deletion. Can we close it now? Thanks.

          niu Niu Yawei (Inactive) added a comment - Minh, USE_OFD is obsolete now and test_33() in master do have syc_all_data after deletion. Can we close it now? Thanks.

          I think it might because the test_33() doesn't sync_all_data for zfs after the deletion.

          Hi, Minh
          Could you add a "sync; sync_all_data;" after the "wait_delete_completed" in test_33() to see if it can resolve your problem? (Sorry, I don't have zfs test environment by hand). Thanks.

          For the problem of "error: set_param: /proc/

          {fs,sys}

          /

          {lnet,lustre}

          /lquota/lustre-OST*/stats: Found no match", I think we need to check if USE_OFD is set in
          run_test_with_stat() and skip checking the quota stats when USE_OFD is set.

          niu Niu Yawei (Inactive) added a comment - I think it might because the test_33() doesn't sync_all_data for zfs after the deletion. Hi, Minh Could you add a "sync; sync_all_data;" after the "wait_delete_completed" in test_33() to see if it can resolve your problem? (Sorry, I don't have zfs test environment by hand). Thanks. For the problem of "error: set_param: /proc/ {fs,sys} / {lnet,lustre} /lquota/lustre-OST*/stats: Found no match", I think we need to check if USE_OFD is set in run_test_with_stat() and skip checking the quota stats when USE_OFD is set.
          mdiep Minh Diep added a comment -

          Assign this to Niu to investigate further - thanks

          mdiep Minh Diep added a comment - Assign this to Niu to investigate further - thanks

          Minh, was this on master or b2_3?
          I think b2_3 misses http://review.whamcloud.com/3470, although i don't think this can explain the issue of space not released from accounting after delete.
          In any case, i think we should rebase the quota accounting tests on the ones in orion. Niu, could you please handle that?

          Thanks in advance.

          johann Johann Lombardi (Inactive) added a comment - Minh, was this on master or b2_3? I think b2_3 misses http://review.whamcloud.com/3470 , although i don't think this can explain the issue of space not released from accounting after delete. In any case, i think we should rebase the quota accounting tests on the ones in orion. Niu, could you please handle that? Thanks in advance.
          mdiep Minh Diep added a comment -

          Johann, Something is wrong here. the fs started clean and quota still fail after delete

          https://maloo.whamcloud.com/test_sessions/99e4c32c-0080-11e2-860a-52540035b04c

          mdiep Minh Diep added a comment - Johann, Something is wrong here. the fs started clean and quota still fail after delete https://maloo.whamcloud.com/test_sessions/99e4c32c-0080-11e2-860a-52540035b04c

          Minh, it seems that the filesystem wasn't clean and the quota_user already had some existing files which confused the test.

          johann Johann Lombardi (Inactive) added a comment - Minh, it seems that the filesystem wasn't clean and the quota_user already had some existing files which confused the test.
          mdiep Minh Diep added a comment -

          https://maloo.whamcloud.com/test_sets/b8a16670-fe7e-11e1-a707-52540035b04c
          shows 33 and 34 failed. Could you please check it?

          mdiep Minh Diep added a comment - https://maloo.whamcloud.com/test_sets/b8a16670-fe7e-11e1-a707-52540035b04c shows 33 and 34 failed. Could you please check it?

          Only accounting is supported for now, so only 33-35 should be run. Other tests can't pass for now.

          johann Johann Lombardi (Inactive) added a comment - Only accounting is supported for now, so only 33-35 should be run. Other tests can't pass for now.
          mdiep Minh Diep added a comment -

          Johann,

          sorry for not being clear. I ran this manually after removed the ONLY. I wanted to see if we can run all the tests with a little fix. If you think we only require to run 33-35. I can do that. Please let me know.

          mdiep Minh Diep added a comment - Johann, sorry for not being clear. I ran this manually after removed the ONLY. I wanted to see if we can run all the tests with a little fix. If you think we only require to run 33-35. I can do that. Please let me know.

          People

            niu Niu Yawei (Inactive)
            maloo Maloo
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: